ListPayments: filter out non-succeeded payments, include payment status #3190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpaulino
approved these changes
Jun 12, 2019
Contributor
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
LGTM 💫
Note: the status will show in the lncli response as UNKNOWN, SUCCEEDED, IN_FLIGHT, and FAILED for those wondering.
Member
|
Fails existing integration tests: |
Also make it optional to list non-succeeded payments.
Earlier versions of ListPayments only included completed payments. We return to this behavior by ignore all other payments if the nonSucceeded boolean is not set in the request.
halseth
force-pushed
the
listpayments-status-filter
branch
from
608b18b to
0aec3fd
Compare
cfromknecht
reviewed
Jun 12, 2019
|
|
||
| message ListPaymentsRequest { | ||
| /// Set to also return payments that are not (yet) succeeded. | ||
| bool non_succeeded = 1; |
Contributor
There was a problem hiding this comment.
naming suggestion: include_incomplete or include_unsuccessful?
|
|
||
| // convertPaymentStatus converts a channeldb.PaymentStatus to the type expected | ||
| // by the RPC. | ||
| func convertPaymentStatus(dbStatus channeldb.PaymentStatus) ( |
Contributor
There was a problem hiding this comment.
is this something that could be defined in lnrpc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of ListPayments only included completed payments. We
return to this behavior by ignore all other payments if the
nonSucceededboolean is not set in the request