lnwallet/btcwallet: use relay fee not tx fee rate for dust check #3218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit we fix a hidden bug in the transaction creating logic that was only manifested recently due to higher fees on Bitcoin's mainnet. Before this commit, we would use the target fee rate to determine if an output was dust or not. However, this is incorrect, as instead the relay fee should be used as this matches the policy checks widely deployed in Bitcoin full node today. To fix this issue we now properly use the relay fee when computing dust. This fixes the issue for the `EstimateFee` call, but the `SendOutputs` call also has a similar issue. However, this must be fixed within `btcwallet` itself, so it has been left out of this commit Fixes lightningnetwork#3217.
In this commit, we fix a logic flaw in the testCreateSimpleTx test case which emerged once we the bug fix for dust outputs landed. Before this commit, we would erroneously fail during valid test execution.
Roasbeef
force-pushed
the
fee-estimate-fee-dust
branch
from
51a0fba to
4203542
Compare
wpaulino
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit we fix a hidden bug in the transaction creating logic
that was only manifested recently due to higher fees on Bitcoin's
mainnet. Before this commit, we would use the target fee rate to
determine if an output was dust or not. However, this is incorrect, as
instead the relay fee should be used as this matches the policy checks
widely deployed in Bitcoin full node today.
To fix this issue we now properly use the relay fee when computing dust.
This fixes the issue for the
EstimateFeecall, but theSendOutputscall also has a similar issue. However, this must be fixed within
btcwalletitself, so it has been left out of this commitFixes #3217.