Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peer: don't reply to requests for `initial_graph_sync` #3314

Merged

Conversation

@cfromknecht
Copy link
Collaborator

commented Jul 15, 2019

We stopped requesting this from other nodes as it is very expensive as
the graph continues to grow. In this commit we will also stop
responding, as nodes are recommended to begin using the gossip_queries
and upcoming extended_gossip_queries to reconcile missing graph data.

cfromknecht added some commits Jul 15, 2019

peer: don't reply if peer's request `initial_graph_sync`
We stopped requesting this from other nodes as it is very expensive as
the graph continues to grow. In this commit we will also stop
responding, as nodes are recommended to begin using the `gossip_queries`
and upcoming `extended_gossip_queries` to reconcile missing graph data.
@wpaulino
Copy link
Collaborator

left a comment

LGTM 🔮

@halseth
Copy link
Collaborator

left a comment

LGTM 🤓 🔴 🔺🔴 🔺🔴🔺 🔴 🔴 🔺🔺

@cfromknecht cfromknecht added the v0.7.1 label Jul 16, 2019

@cfromknecht cfromknecht added this to the 0.7.1 milestone Jul 16, 2019

@Roasbeef Roasbeef merged commit 3faece1 into lightningnetwork:master Jul 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 60.584%
Details

@cfromknecht cfromknecht deleted the cfromknecht:remove-initial-graph-sync branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.