Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: flag flip no historical gossip #3359

Merged

Conversation

@cfromknecht
Copy link
Collaborator

commented Jul 30, 2019

This PR adds the ignore-historical-filters CLI option, initially
defaulting to false. Users may use this option to prevent lnd from doing
historical gossip dumps to peers that set their gossip_timestamp_range
in the past. Enabling this option will result in lower bandwidth and
memory consumption. Down the road the plan is to make this default to
true.

@cfromknecht cfromknecht added this to the 0.8.0 milestone Jul 30, 2019

@cfromknecht cfromknecht added the v0.8.0 label Jul 30, 2019

@cfromknecht cfromknecht changed the title Flag flip no historical gossip discovery: flag flip no historical gossip Jul 30, 2019

@wpaulino
Copy link
Collaborator

left a comment

LGTM 💫

Looks like Eclair also sends out the current timestamp as the start of the range, though c-lightning can vary depending on how much gossip they've ingested.

@Roasbeef
Copy link
Member

left a comment

Pretty compact diff, reads well at first pass through. Only main comment is to add a new test to exercise ignoring the backlog for a gossip syncer if the new flag is set.

@cfromknecht cfromknecht force-pushed the cfromknecht:flag-flip-no-historical-gossip branch from 05dd494 to 09a46dc Jul 31, 2019

cfromknecht added some commits Jul 31, 2019

config+server: add ignore-historical-filters CLI option
This commit adds the ignore-historical-filters CLI option, initially
defaulting to false. Users may use this option to prevent lnd from doing
historical gossip dumps to peers that set their `gossip_timestamp_range`
in the past. Enabling this option will result in lower bandwidth and
memory consumption. Down the road the plan is to make this default to
true.

@cfromknecht cfromknecht force-pushed the cfromknecht:flag-flip-no-historical-gossip branch from 09a46dc to 9947190 Jul 31, 2019

@cfromknecht

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 31, 2019

@Roasbeef test added, stripped the existing test from #3315 so should make the code removal at that point simpler as well

@halseth
Copy link
Collaborator

left a comment

LGTM 🐻

@Roasbeef
Copy link
Member

left a comment

LGTM 📊

@Roasbeef Roasbeef merged commit 6e9e0ea into lightningnetwork:master Aug 2, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 60.736%
Details

@cfromknecht cfromknecht deleted the cfromknecht:flag-flip-no-historical-gossip branch Aug 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.