REST: increase max msg size for REST proxy #3379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some time ago, we modified `lncli` to accept larger responses from the server, up to 50MB. However, we failed to update the REST proxy, which is in a sense, a client to the regular RPC server. As a result, users can't currently hit the `/v1/graph` endpoint, as it'll fail with an error. In this PR, we update the proxy's dial options to allow it to receive larger responses from the actual gRPC server. This is only a temporary measure however, as we'll eventually want to expose some sort of pagination for the end client.
Roasbeef
force-pushed
the
rest-describe-graph
branch
from
a3e676c to
764099c
Compare
wpaulino
approved these changes
Aug 7, 2019
| restDialOpts := []grpc.DialOption{ | ||
| grpc.WithTransportCredentials(*restCreds), | ||
| grpc.WithDefaultCallOptions( | ||
| grpc.MaxCallRecvMsgSize(1 * 1024 * 1024 * 50), |
Contributor
There was a problem hiding this comment.
Nit: since it's also defined in cmd/lncli, we could extract the const here and import it there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, we modified
lnclito accept larger responses from theserver, up to 50MB. However, we failed to update the REST proxy, which
is in a sense, a client to the regular RPC server. As a result, users
can't currently hit the
/v1/graphendpoint, as it'll fail with anerror.
In this PR, we update the proxy's dial options to allow it to receive
larger responses from the actual gRPC server. This is only a temporary
measure however, as we'll eventually want to expose some sort of
pagination for the end client.