htlcswitch+invoices: always return incorrect_or_unknown_payment_details #3391
Conversation
Align naming better with the lightning spec. Not the full name of the failure (FailIncorrectOrUnknownPaymentDetails) is used, because this would cause too many long lines in the code.
This commit fixes exit hop behavior to be in line with the lightning spec.
Previously the time lock in the onion payload was reported. This is no new information to the sender.
In order to prevent information leaks by nodes probing with a payment hash, this commit changes exit hop processing so that it always returns incorrect_or_unknown_payment_details and leaves the prober in the dark about whether an invoice actually exists.
| @@ -1025,9 +1020,8 @@ func TestChannelLinkMultiHopInsufficientPayment(t *testing.T) { | |||
| ).Wait(30 * time.Second) | |||
| if err == nil { | |||
| t.Fatal("error haven't been received") | |||
| } else if !strings.Contains(err.Error(), "insufficient capacity") { | |||
There was a problem hiding this comment.
It may still be useful to report the error string we give out, for the sake of the RPC client. So we'd also extend this new assertFailureCode method to still assert our internal string.
There was a problem hiding this comment.
This sounds like a test that does not belong here. Is it right that you want tests that ensure that we return a specific string for an error over the rpc interface? In that case I'd think we should add those to lnwire. But how relevant is this really? We move to structured errors for SendToRoute, so for that call these strings won't appear anymore. Also SendPayment is moving to higher level structured messages.
| // HtlcCancelReason defines reasons for which htlcs can be canceled. | ||
| type HtlcCancelReason uint8 | ||
|
|
||
| const ( |
There was a problem hiding this comment.
It may still be useful to log this information internally for debugging purposes (dev using two nodes on simnet for example).
There was a problem hiding this comment.
We do, see the debugLog statements in NotifyExitHopHtlc
In order to prevent information leaks by nodes probing with a payment hash, this commit changes exit hop processing so that it always returns incorrect_or_unknown_payment_details and leaves the prober in the dark about whether an invoice actually exists.
This implements part of lightning/bolts#608 by removing the deprecated failure message
FinalExpiryTooSoon. This won't affect payment reliability, because this error was considered final just asIncorrectOrUnknownPaymentDetailsis.The follow up of this PR is #3186 in which the accepted height is reported, allowing senders to distinguish between incorrect details and delays on the forward path.