Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

channeldb: remove older migrations #3485

Merged
merged 2 commits into from Sep 14, 2019

Conversation

@joostjager
Copy link
Collaborator

commented Sep 10, 2019

To reduce maintenance on migration code, we move to only supporting upgrades from previous major releases.

@joostjager joostjager requested review from Roasbeef and halseth Sep 10, 2019
@wpaulino wpaulino added this to the 0.8.0 milestone Sep 10, 2019
channeldb/error.go Outdated Show resolved Hide resolved
channeldb/db.go Outdated Show resolved Hide resolved
channeldb/db.go Show resolved Hide resolved
@joostjager joostjager force-pushed the joostjager:remove-migrations branch from 8ce8a64 to feee4d8 Sep 11, 2019
@joostjager joostjager requested a review from halseth Sep 11, 2019
Copy link
Collaborator

left a comment

LGTM

@joostjager joostjager requested review from cfromknecht and removed request for Roasbeef Sep 12, 2019
joostjager added 2 commits Sep 10, 2019
To reduce maintenance on migration code, we move to only supporting
upgrades from previous major releases.
Copy link
Member

left a comment

LGTM 🎉

Copy link
Collaborator

left a comment

feels good to 🧨old code, LGTM

@@ -1168,6 +1176,21 @@ func getLatestDBVersion(versions []version) uint32 {
return versions[len(versions)-1].number
}

// getMinUpgradeVersion returns the minimum version required to upgrade the
// database.
func getMinUpgradeVersion(versions []version) uint32 {

This comment has been minimized.

Copy link
@cfromknecht

cfromknecht Sep 13, 2019

Collaborator

not a blocker, but now that we're removing migrations, this logic should probably be able to handle the case where there are no migrations in a given release. would need a similar change to getLatestDBVersion as well

@Roasbeef Roasbeef merged commit 550a7a0 into lightningnetwork:master Sep 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.