htlcswitch: fix non-strict forwarding failures #3547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostjager
changed the title
cfromknecht
reviewed
Sep 29, 2019
Contributor
cfromknecht
left a comment
cfromknecht
left a comment
There was a problem hiding this comment.
Nice fix and refactor!
joostjager
force-pushed
the
non-strict-error
branch
from
8166576 to
c01c2e7
Compare
cfromknecht
approved these changes
Sep 30, 2019
Roasbeef
requested changes
Oct 9, 2019
joostjager
force-pushed
the
non-strict-error
branch
5 times, most recently
from
acb7e9b to
8de45d9
Compare
Roasbeef
approved these changes
Oct 23, 2019
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
LGTM ☄️
Needs a rebase, then ready to land!
htlcswitch/test_utils.go
Outdated
This is already checked in EligibleToForward()
In the scenario where the requested channel does not have enough balance and another channel towards the same node generates a different failure, we erroneously returned UnknownNextPeer instead of the expected TemporaryChannelFailure. This commit rewrites the non-strict forwarding logic in the switch to return the proper failure message. Part of this is moving the link balance check inside the link.
joostjager
force-pushed
the
non-strict-error
branch
from
8de45d9 to
200be87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes inconsistencies in the returned failure messages when forwarding non-strict.