Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flat features #3685

Merged
merged 5 commits into from Nov 9, 2019
Merged

flat features #3685

merged 5 commits into from Nov 9, 2019

Conversation

cfromknecht
Copy link
Collaborator

@cfromknecht cfromknecht commented Nov 7, 2019

An implementation of lightning/bolts#666

@cfromknecht cfromknecht force-pushed the flat-features branch 2 times, most recently from aec5dae to 3e64047 Compare Nov 8, 2019
@cfromknecht cfromknecht marked this pull request as ready for review Nov 8, 2019
@cfromknecht cfromknecht added this to WIP in v0.9.0-beta via automation Nov 8, 2019
@cfromknecht cfromknecht added this to the 0.9.0 milestone Nov 8, 2019
@cfromknecht cfromknecht moved this from WIP to Needs Review in v0.9.0-beta Nov 8, 2019
Copy link
Collaborator

@joostjager joostjager left a comment

First pass looking good. Main comment is about order of commits

channeldb/migration_01_to_11/graph.go Outdated Show resolved Hide resolved
peer.go Outdated Show resolved Hide resolved
feature/manager_test.go Outdated Show resolved Hide resolved
feature/default_sets.go Outdated Show resolved Hide resolved
@cfromknecht cfromknecht force-pushed the flat-features branch 4 times, most recently from 77cea27 to 9f80240 Compare Nov 8, 2019
Copy link
Collaborator

@joostjager joostjager left a comment

Nice restructuring

lnwire/init_message.go Outdated Show resolved Hide resolved
@cfromknecht cfromknecht force-pushed the flat-features branch 4 times, most recently from b13cb6d to 79a0753 Compare Nov 8, 2019
@halseth halseth removed request for wpaulino and Roasbeef Nov 8, 2019
lnwire/features.go Show resolved Hide resolved
feature/manager.go Show resolved Hide resolved
lnwire/features.go Outdated Show resolved Hide resolved
lnwire/features.go Outdated Show resolved Hide resolved
feature/manager.go Show resolved Hide resolved
server.go Show resolved Hide resolved
lnpeer/peer.go Show resolved Hide resolved
lnpeer/peer.go Outdated Show resolved Hide resolved
peer.go Outdated Show resolved Hide resolved
peer.go Show resolved Hide resolved
cfromknecht added 2 commits Nov 8, 2019
This commit introduces a feature.Manager, which derives feature vectors
for various contexts within the daemon. The sets can be described via a
staticly compiled format, which makes any runtime adjustments to the
feature sets when the manager is initialized.
halseth
halseth approved these changes Nov 8, 2019
Copy link
Collaborator

@halseth halseth left a comment

LGTM 💯

v0.9.0-beta automation moved this from Needs Review to Approved Nov 8, 2019
Copy link
Member

@Roasbeef Roasbeef left a comment

Clean set of changes! We should wait on merge until we confirm proper interop tests w/ the other main implementations, and also for the final version of the spec to be merged.

LGTM 💥

@joostjager joostjager merged commit b222b6e into lightningnetwork:master Nov 9, 2019
1 of 2 checks passed
v0.9.0-beta automation moved this from Approved to Done Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v0.9.0-beta
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants