Repository navigation
routing: use distinct probability estimation for local channels - #3686
Merged
Merged
Conversation
Previously we used the a priori probability also for our own untried channels. This led to local channels that had seen a success already being prioritized over untried local channels. In some cases, depending on the configured payment attempt cost, this could lead to the payment taking a two hop route while a direct payment was also possible.
joostjager
requested review from
guggero and
halseth
and removed request for
Roasbeef and
halseth
November 7, 2019 12:11
guggero
approved these changes
Nov 7, 2019
guggero
left a comment
guggero
left a comment
Collaborator
There was a problem hiding this comment.
LGTM 💯
Nice, clean and easy to understand PR, nice work!
cfromknecht
reviewed
Nov 8, 2019
cfromknecht
left a comment
cfromknecht
left a comment
Contributor
There was a problem hiding this comment.
Overall PR looks good, one minor comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we used the a priori probability also for our own untried channels. This led to local channels that had seen a success already being prioritized over untried local channels. In some cases, depending
on the configured payment attempt cost, this could lead to the payment taking a two hop route while a direct payment was also possible.