Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: use distinct probability estimation for local channels #3686

Merged
merged 2 commits into from Nov 8, 2019

Conversation

joostjager
Copy link
Collaborator

@joostjager joostjager commented Nov 7, 2019

Previously we used the a priori probability also for our own untried channels. This led to local channels that had seen a success already being prioritized over untried local channels. In some cases, depending
on the configured payment attempt cost, this could lead to the payment taking a two hop route while a direct payment was also possible.

joostjager added 2 commits Nov 7, 2019
Previously we used the a priori probability also for our own untried
channels. This led to local channels that had seen a success already
being prioritized over untried local channels. In some cases, depending
on the configured payment attempt cost, this could lead to the payment
taking a two hop route while a direct payment was also possible.
@joostjager joostjager self-assigned this Nov 7, 2019
@joostjager joostjager added this to WIP in v0.9.0-beta via automation Nov 7, 2019
@joostjager joostjager added this to the 0.9.0 milestone Nov 7, 2019
@joostjager joostjager added mission control payments routing labels Nov 7, 2019
@joostjager joostjager requested review from halseth and guggero and removed request for Roasbeef and halseth Nov 7, 2019
@joostjager joostjager moved this from WIP to Needs Review in v0.9.0-beta Nov 7, 2019
guggero
guggero approved these changes Nov 7, 2019
Copy link
Collaborator

@guggero guggero left a comment

LGTM 💯
Nice, clean and easy to understand PR, nice work!

Copy link
Collaborator

@cfromknecht cfromknecht left a comment

Overall PR looks good, one minor comment

routing/probability_estimator.go Show resolved Hide resolved
@joostjager joostjager requested a review from cfromknecht Nov 8, 2019
v0.9.0-beta automation moved this from Needs Review to Approved Nov 8, 2019
Copy link
Collaborator

@cfromknecht cfromknecht left a comment

LGTM

@cfromknecht cfromknecht merged commit 92fb5ac into lightningnetwork:master Nov 8, 2019
1 of 2 checks passed
v0.9.0-beta automation moved this from Approved to Done Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v0.9.0-beta
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants