Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Warn user before doing SCB restore #3698
SCB restore closes all open channels, which may result in significant on-chain fees.
The current implementation of lncli create does not warn users.
We need to warn users that this is what will happen if they try to do an SCB restore, and get their affirmative consent.
I agree, we should suppress this warning if there are no open channels. Furthermore, we should show the number of open channels in the warning.
I am not sure if at that stage of lnd's boot process, lncli can access the current open channels. I'll have to see if that is possible. Let me dig around. I'm new to this codebase
carlaKC left a comment
Thanks for the PR @aantonop! I think that this is going to be really helpful to people
I deeply feel your linter pain, also took me a while to get travis happy
For a change like this, we'd tend to only have on commit, so would you mind doing an interactive rebase and squashing the correction commits down?
And welcome to the golang way of life
guggero left a comment
Thank you for your contribution, @aantonop!
So I'm sorry that I have to be nit picking again, mostly on the formatting of the comments.