lnrpc+routerrpc+lncli: add msat fields#3706
Merged
joostjager merged 2 commits intolightningnetwork:masterfrom Nov 14, 2019
Merged
lnrpc+routerrpc+lncli: add msat fields#3706joostjager merged 2 commits intolightningnetwork:masterfrom
joostjager merged 2 commits intolightningnetwork:masterfrom
Conversation
joostjager
added
rpc
joostjager
force-pushed
the
pay-msat
branch
2 times, most recently
from
734cf41 to
79d46bb
Compare
wpaulino
reviewed
Nov 11, 2019
guggero
reviewed
Nov 12, 2019
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice to see more consistency in the API!
If we introduce a braking change in the API anyway, wouldn't this be the moment to also just get rid of the sat amounts and only deal with msat? Or at least deprecate them and remove in the next release?
Contributor
Author
Get rid of it is also a breaking change on the wire level. So that needs to be preceded with deprecation first. Outstanding question on that above |
joostjager
force-pushed
the
pay-msat
branch
2 times, most recently
from
23be804 to
c980d8a
Compare
Contributor
Author
|
Left existing field unchanged, to prevent cascading changes in projects that depend on it. |
wpaulino
approved these changes
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lightning supports payments at the msat granularity, but
lnddoes not expose this on the rpc interface. This PR adds msat fields for payment amounts and fee limits.Fixes #3689
NOTE: This renames some of the existing rpc fields which is a breaking change for users building against our proto files. The change doesn't change anything on the wire level.