New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chanbackup: continue recovery if channel already exists #3737
Conversation
@Roasbeef bump as potential candidate for 0.8.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sound change. I've also seen instances in the past where a user hits CRTL-C early because things are taking too long, but then can't restart the process easily.
Small diff, so no major comments, but it would be nice to have a test for this either at the unit test, or integration test level, to ensure we're checking the proper error (though at a cursory scan, it looks correct to me).
Added a test on the itest level to make sure an SCB file can be imported twice without running into an error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🍁
While recovering a multi backup file, if for some reason one of the channels in that backup already exists, the whole recovery is aborted.
This leaves the restore in a half-finished state and a re-try or resume is not possible.
With this small fix, the same multi-file can be added again and all channels that were not imported before can now be added.