Skip to content

[mobile] Update readme and comments#3748

Merged
Roasbeef merged 3 commits into
lightningnetwork:masterfrom
halseth:falafel-updates
Nov 25, 2019
Merged

[mobile] Update readme and comments#3748
Roasbeef merged 3 commits into
lightningnetwork:masterfrom
halseth:falafel-updates

Conversation

@halseth

@halseth halseth commented Nov 21, 2019

Copy link
Copy Markdown
Contributor
  • Point to lightninglabs fork of falafel.
  • Add more comments to build script.

Comment thread mobile/gen_bindings.sh
listeners="lightning=lightningLis walletunlocker=walletUnlockerLis"

# Set to 1 to create boiler plate grpc client code and listeners. If more than
# one proto file is being parsed, it should only be done once.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should only be done once?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating the boiler plate code 😅

@Roasbeef Roasbeef left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎏

@Roasbeef Roasbeef merged commit ff268ac into lightningnetwork:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants