Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mobile] Update readme and comments #3748

Merged
merged 3 commits into from
Nov 25, 2019
Merged

[mobile] Update readme and comments #3748

merged 3 commits into from
Nov 25, 2019

Conversation

halseth
Copy link
Contributor

@halseth halseth commented Nov 21, 2019

  • Point to lightninglabs fork of falafel.
  • Add more comments to build script.

cfromknecht
cfromknecht approved these changes Nov 22, 2019
View reviewed changes
mobile/gen_bindings.sh
listeners="lightning=lightningLis walletunlocker=walletUnlockerLis"

# Set to 1 to create boiler plate grpc client code and listeners. If more than
# one proto file is being parsed, it should only be done once.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what should only be done once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

creating the boiler plate code 😅

Roasbeef
Roasbeef approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎏

@Roasbeef Roasbeef merged commit ff268ac into lightningnetwork:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfromknecht cfromknecht cfromknecht approved these changes

@Roasbeef Roasbeef Roasbeef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@halseth @Roasbeef @cfromknecht