Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zpay32: Fix broken last tagged field #3767

Merged
merged 3 commits into from Dec 5, 2019
Merged

zpay32: Fix broken last tagged field #3767

merged 3 commits into from Dec 5, 2019

Commits on Nov 26, 2019

  1. zpay32: Switch to ErrInvalidFieldLength sentinel 

    This switches the applicable error to use an exported sentinel error so
that it is more testable.
    @matheusd
    matheusd committed Nov 26, 2019
    Copy the full SHA
    85f9c03 View commit details
    Browse the repository at this point in the history

  2. zpay32: Fix broken last tagged field 

    This fixes an issue where the last tagged field of an invoice could get
broken due to the malleability of bech32 checksums.

The addition of a specific character in the second to last position of
the checksum could cause the previous signature field to mutate and thus
point to a different public node.
    @matheusd
    matheusd committed Nov 26, 2019
    Copy the full SHA
    409cf55 View commit details
    Browse the repository at this point in the history

  3. zpay32: Add tests of checksum malleability 

    This adds tests for checksum malleability issue of bech32 strings as
used by LN invoices.
    @matheusd
    matheusd committed Nov 26, 2019
    Copy the full SHA
    cf6ae06 View commit details
    Browse the repository at this point in the history