Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anchors] Pluggable commitments #3773

Closed

Conversation

@halseth
Copy link
Collaborator

halseth commented Nov 28, 2019

As a preparation for the anchor output commitment type, we abstract the current (tweak/tweakless) commitment types behind an interface to make it easier to work with in the channel state machine.

@halseth halseth force-pushed the halseth:pluggable-commitments branch from da6beec to ab50a39 Nov 28, 2019
halseth added 3 commits Nov 28, 2019
We define a new interface CommitmentType, that abstracts away how keys
are generated for the different commitment types (currently
tweak(less)).

Intention is that more of the logic that is unique for each commitment
type is behind the interface, making the channel state machine oblivious
to the kays and outputs being created on the commitment tx for a given
channel state.
To make the channel state machine less concerned about the type of
commitment, we nil the local tweak when creating the keyring, depending
on the commitment type.
@halseth halseth force-pushed the halseth:pluggable-commitments branch from ab50a39 to 0033e4f Nov 28, 2019
@halseth halseth added the anchors label Dec 5, 2019
@halseth

This comment has been minimized.

Copy link
Collaborator Author

halseth commented Dec 13, 2019

Replaced by #3829

@halseth halseth closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.