routing: improve equal cost route comparison#3782
Merged
joostjager merged 1 commit intolightningnetwork:masterfrom Dec 3, 2019
Merged
routing: improve equal cost route comparison#3782joostjager merged 1 commit intolightningnetwork:masterfrom
joostjager merged 1 commit intolightningnetwork:masterfrom
Conversation
joostjager
force-pushed
the
zero-attempt-cost-prob
branch
from
5193141 to
ac70bd3
Compare
joostjager
requested review from
guggero and
wpaulino
and removed request for
Roasbeef
guggero
approved these changes
Dec 2, 2019
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Nice, looks good to me!
Is it maybe worth adding a test for this? Or is this too trivial a change?
joostjager
force-pushed
the
zero-attempt-cost-prob
branch
from
ac70bd3 to
0772150
Compare
When the (virtual) payment attempt cost is set to zero, probabilities are no longer a factor in determining the best route. In case of routes with equal costs, we'd just go with the first one found. This commit refines this behavior by picking the route with the highest probability. So even though probability doesn't affect the route cost, it is still used as a tie breaker.
joostjager
force-pushed
the
zero-attempt-cost-prob
branch
from
0772150 to
3aaf32d
Compare
Contributor
Author
|
Test added. Also ran into the heap comparison, which I updated as well. |
guggero
approved these changes
Dec 2, 2019
wpaulino
approved these changes
Dec 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the (virtual) payment attempt cost is set to zero, probabilities are no longer a factor in determining the best route. In case of routes with equal costs, we'd just go with the first one found. This commit refines this behavior by picking the route with the highest probability. So even though probability doesn't affect the route cost, it is still used as a tie breaker.