[mobile] mobile macaroons support #3783
Conversation
halseth
force-pushed
the
mobile-macaroons
branch
from
570d524
to
f0586e3
Compare
lnd.go
Outdated
| @@ -59,24 +60,72 @@ var ( | |||
| networkDir string | |||
| ) | |||
|
|
|||
| // Creds is a list of DialOptions that can be used to authenticate with | |||
There was a problem hiding this comment.
I think the comment may be off.
lnd.go
Outdated
| func Authenticate() ([]grpc.DialOption, error) { | ||
| creds, err := credentials.NewClientTLSFromFile(cfg.TLSCertPath, "") | ||
| if err != nil { | ||
| return nil, fmt.Errorf("unable to read TLC cert: %v", err) |
| } | ||
|
|
||
| // Get the admin macaroon if macaroons are active. | ||
| if !cfg.NoMacaroons { |
There was a problem hiding this comment.
nit: I know this is not part of this PR just double negation looks a bit weird :)
There was a problem hiding this comment.
Yeah, it is a result of macaroons being default and have to be turned off 😂
| "path (check the network setting!): %v", err) | ||
| } | ||
|
|
||
| mac := &macaroon.Macaroon{} |
There was a problem hiding this comment.
Is there any downside for having mac on the stack instead?
There was a problem hiding this comment.
I think the compiler mostly takes care of this: https://golang.org/doc/faq#stack_or_heap
| mac := &macaroon.Macaroon{} | ||
| if err = mac.UnmarshalBinary(macBytes); err != nil { | ||
| return nil, fmt.Errorf("unable to decode macaroon: %v", | ||
| err) |
There was a problem hiding this comment.
nit: you could probably move this to one line.
There was a problem hiding this comment.
Line a tad bit too long
lnd.go
Outdated
|
|
||
| // RPCListener can be set to the listener to use for the RPC server. If | ||
| // nil a regular network listener will be created. | ||
| RPCListener net.Listener | ||
| RPCListener *ListenerWithSignal | ||
| } | ||
|
|
||
| // rpcListeners is a function type used for closures that fetches a set of RPC | ||
| // listeners for the current configuration, and the GRPC server options to use |
There was a problem hiding this comment.
I think this godoc needs an update (grpc.ServerOption removed).
lnd.go
Outdated
| // | ||
| // NOTE: This should only be called after the RPCListener has signaled it is | ||
| // ready. | ||
| func Authenticate() ([]grpc.DialOption, error) { |
There was a problem hiding this comment.
Should we maybe call this AdminAuthOptions? To me Authenticate sounds like it's performing an action or doing something other than just returning something.
halseth
force-pushed
the
mobile-macaroons
branch
2 times, most recently
from
2c1e7f6
to
1a69156
Compare
Earlier we used emtpy grpc server options if custom listeners were set. This was done to disable TLS. Now, we reuse the same server options as for the regular listeners, in a move towards enabling TLS also here.
Adds a global Authenticate method that can be used to get the atuhentication options needed to call the grpc server. Currently meant only for used with the mobile bindings, so we use the admin macaroon.
This makes the mobile bindings work with TLS and macaroons enabled, which is supported from falafel 0.6.
halseth
force-pushed
the
mobile-macaroons
branch
from
1a69156
to
5be6e1c
Compare
Now that macaroons are supported, encourage usage.
This adds initial macaroon support for mobile lnd.
Currently the admin macaroon is used, in the future we can be more granular, even let the applications supply macaroons themselves.
Builds on #3775
Depends on