parse and generate bolt 11 invoices w/ payment addrs#3788
Merged
cfromknecht merged 4 commits intolightningnetwork:masterfrom Dec 5, 2019
Merged
parse and generate bolt 11 invoices w/ payment addrs#3788cfromknecht merged 4 commits intolightningnetwork:masterfrom
cfromknecht merged 4 commits intolightningnetwork:masterfrom
Conversation
cfromknecht
requested review from
joostjager
and removed request for
Roasbeef
cfromknecht
changed the title
cfromknecht
force-pushed
the
payment-addr
branch
from
cd5fe80 to
f683c69
Compare
joostjager
reviewed
Dec 5, 2019
This commit also consolidates the existing code duplication in parsing payment hashes and description hashes into a single, combined method for parsing 32-byte values. A similar change is made for encoding 32-byte values. zpay32/invoice: consolidate 32-byte encoding logic
This commit modifies Lighting.AddInvoice and InvoicesRPC.AddHoldInvoice to include the node's supported feature bits on the invoice. For now this only includes the optional TLV Onion Payload bit.
cfromknecht
force-pushed
the
payment-addr
branch
from
f683c69 to
abb7f4f
Compare
joostjager
approved these changes
Dec 5, 2019
Contributor
joostjager
left a comment
joostjager
left a comment
There was a problem hiding this comment.
LGTM, assuming CI becomes green
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split off from #3679
This PR:
sfielddecodepayreqThis will enable #3415 to properly test receiving crowd funded mpp payments via the
SendToRouterpcs.