Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[anchor] pluggable anchor commitments #3821
Missing from end-to-end anchors working:
Builds on #3829
joostjager left a comment
This look pretty good. The word anchor disappeared completely from
I still have that ideal in mind where there is a
Roasbeef left a comment
Solid PR! We're soo close
The one thing that seems to be missing from my run through is ensuring that we re-account for the value that we deducted for anchors each time we go to create a new commitment.
…witness script We use the fact that we can tell whether the commit is local or remote by inspecting the witness script. We cannot use the maturity delay anymore, as we can have delayed to_remote outputs also now. Co-authored-by: Joost Jager <firstname.lastname@example.org>
With this commitment type, we'll add extra anchor outputs to the commitment transaction if the anchor channel type is active.
To prepare for adding more commit types to test for basic channel funding, we make the commit type an enum that gets its own set of subtests.
If we are the initiator, we check that our starting balance after subtracting fees are not less than two times the default dust limit. This commit adds a similar check for the non-initiator case, checking that the remote party has a starting balance of reasonable size.