Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing+lnrpc: add missing query routes parameters #3911

Merged
merged 3 commits into from Jan 15, 2020

Conversation

joostjager
Copy link
Collaborator

@joostjager joostjager commented Jan 14, 2020

Over time, several new parameters have been added to the payment RPCs. But QueryRoutes hasn't kept up with those. This PR adds what is missing:

  • Route hints
  • Last hop restriction
  • Outgoing channel restriction
  • Destination node features

Furthermore an inconsistency with the default final cltv delta is fixed.

Fixes #3150

@joostjager joostjager requested a review from Roasbeef as a code owner Jan 14, 2020
@joostjager joostjager added payments routing rpc labels Jan 14, 2020
@joostjager joostjager removed the request for review from Roasbeef Jan 14, 2020
@joostjager joostjager added this to the 0.9.0 milestone Jan 14, 2020
The default was increased for the main sendpayment RPC in commit
d3fa976. This commit sets the
same default for QueryRoutes, routerrpc.SendPayment and
router.EstimateRouteFee.
Copy link
Member

@Roasbeef Roasbeef left a comment

Nice to have this call once again have parity with SendPayment!

LGTM 🎐

@Roasbeef Roasbeef merged commit 269182c into lightningnetwork:master Jan 15, 2020
1 of 2 checks passed
alexbosworth
Copy link
Contributor

@alexbosworth alexbosworth commented on 81bf6e1 Jan 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

depdencies not correct spelling

@C-Otto
Copy link
Contributor

@C-Otto C-Otto commented Jan 17, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
payments routing rpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants