routing+lnrpc: add missing query routes parameters#3911
Merged
Roasbeef merged 3 commits intolightningnetwork:masterfrom Jan 15, 2020
Merged
routing+lnrpc: add missing query routes parameters#3911Roasbeef merged 3 commits intolightningnetwork:masterfrom
Roasbeef merged 3 commits intolightningnetwork:masterfrom
Conversation
joostjager
added
payments
The default was increased for the main sendpayment RPC in commit d3fa976. This commit sets the same default for QueryRoutes, routerrpc.SendPayment and router.EstimateRouteFee.
Roasbeef
approved these changes
Jan 15, 2020
Member
Roasbeef
left a comment
Roasbeef
left a comment
There was a problem hiding this comment.
Nice to have this call once again have parity with SendPayment!
LGTM 🎐
C-Otto
added a commit
to C-Otto/rebalance-lnd
that referenced
this pull request
Jan 17, 2020
Contributor
Tryiimaggie
approved these changes
Jul 27, 2024
| @@ -1402,14 +1402,8 @@ type routingMsg struct { | |||
| func (r *ChannelRouter) FindRoute(source, target route.Vertex, | |||
| amt lnwire.MilliSatoshi, restrictions *RestrictParams, | |||
| @@ -1402,14 +1402,8 @@ type routingMsg struct { | |||
| func (r *ChannelRouter) FindRoute(source, target route.Vertex, | |||
| amt lnwire.MilliSatoshi, restrictions *RestrictParams, | |||
nova-smith702prv5
added a commit
to nova-smith702prv5/rebalance-lnd
that referenced
this pull request
Sep 29, 2025
gas-optimizer380m
added a commit
to gas-optimizer380m/rebalance-lnd
that referenced
this pull request
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over time, several new parameters have been added to the payment RPCs. But
QueryRouteshasn't kept up with those. This PR adds what is missing:Furthermore an inconsistency with the default final cltv delta is fixed.
Fixes #3150