Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

routing: penalize node-level failures harder #3945

Merged
merged 1 commit into from Jan 25, 2020

Conversation

@joostjager
Copy link
Collaborator

joostjager commented Jan 21, 2020

Previously we only penalized the outgoing connections of a failing node. This turned out not to be sufficient, because the next route sometimes went into the same failing node again to try a different outgoing connection that wasn't yet known to mission control and therefore not penalized before.

Previously we only penalized the outgoing connections of a failing node.
This turned out not to be sufficient, because the next route sometimes
went into the same failing node again to try a different outgoing
connection that wasn't yet known to mission control and therefore not
penalized before.
@joostjager joostjager force-pushed the joostjager:node-level-penalty branch from c6025d4 to ef28d2a Jan 21, 2020
@joostjager joostjager requested review from cfromknecht and halseth and removed request for Roasbeef Jan 21, 2020
// reverse the pair. We don't want to affect the score of the node
// sending towards the failing node.
// getPair is penalized in the original and the reversed direction. Note
// that this will also affect the score of the failing node's peers.

This comment has been minimized.

Copy link
@halseth

halseth Jan 21, 2020

Collaborator

So node A can impact the score of node B by just not forwarding payments to it?

This comment has been minimized.

Copy link
@joostjager

joostjager Jan 21, 2020

Author Collaborator

Yes, that's true. You become less popular if you have bad friends. But this mainly affects A's link to B specifically.

@joostjager joostjager requested a review from halseth Jan 21, 2020
Copy link
Collaborator

cfromknecht left a comment

LGTM 🎉

Copy link
Collaborator

halseth left a comment

LGTM 👍

@halseth halseth merged commit 1dadce7 into lightningnetwork:master Jan 25, 2020
1 of 2 checks passed
1 of 2 checks passed
coverage/coveralls Coverage decreased (-0.008%) to 62.96%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.