Skip to content

walletrpc: add new PSBT creation+signing RPCs#4389

Merged
guggero merged 10 commits into
lightningnetwork:masterfrom
guggero:psbt-signing
Oct 3, 2020
Merged

walletrpc: add new PSBT creation+signing RPCs#4389
guggero merged 10 commits into
lightningnetwork:masterfrom
guggero:psbt-signing

Conversation

@guggero
Copy link
Copy Markdown
Collaborator

@guggero guggero commented Jun 18, 2020 •
edited
Loading

Fixes #3938.
Fixes #4400.

Depends on btcsuite/btcutil#178 and btcsuite/btcwallet#711.

EDIT: Depends on btcsuite/btcwallet#721.

@guggero guggero requested review from Roasbeef and wpaulino June 18, 2020 14:16
@guggero guggero force-pushed the psbt-signing branch 3 times, most recently from 1881600 to b20bc35 Compare June 22, 2020 16:58
Roasbeef
Roasbeef requested changes Jun 23, 2020
View reviewed changes
Comment thread lnwallet/chanfunding/psbt_assembler.go Outdated
Comment thread lnwallet/interface.go Outdated
Comment thread lnrpc/rest-annotations.yaml Outdated
Comment thread lnrpc/walletrpc/psbt.go Outdated
Copy link
Copy Markdown
Member

@Roasbeef Roasbeef Jun 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already done within the btcwallet methods? If not, then why not?

Copy link
Copy Markdown
Collaborator Author

@guggero guggero Jun 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, most of this is already done by the wallet. The only thing to check here is that the inputs aren't spent or locked yet.

Comment thread lnrpc/walletrpc/walletkit.proto Outdated
Comment thread cmd/lncli/walletrpc_active.go Outdated
Comment thread cmd/lncli/walletrpc_active.go Outdated
Comment thread cmd/lncli/walletrpc_active.go Outdated
Comment thread cmd/lncli/walletrpc_active.go Outdated
Comment thread lntest/itest/psbt.go Outdated
@Roasbeef Roasbeef added enhancement Improvements to existing features / behaviour psbt rpc Related to the RPC interface wallet The wallet (lnwallet) which LND uses labels Jun 23, 2020
@guggero guggero force-pushed the psbt-signing branch 4 times, most recently from 0040f5c to 41f780a Compare June 26, 2020 17:13
@guggero guggero marked this pull request as ready for review June 26, 2020 17:14
@guggero guggero requested a review from halseth as a code owner June 26, 2020 17:14
@guggero guggero added this to the 0.11.0 milestone Jun 26, 2020
@guggero guggero added the v0.11 label Jun 26, 2020
@guggero guggero removed the request for review from halseth June 26, 2020 17:15
@wpaulino wpaulino mentioned this pull request Jun 29, 2020
Closed
@Roasbeef Roasbeef modified the milestones: 0.11.0, 0.12.0 Jun 30, 2020
@wpaulino wpaulino added v0.12 and removed v0.11 labels Jul 2, 2020
@guggero guggero mentioned this pull request Jul 13, 2020
Merged
@guggero guggero force-pushed the psbt-signing branch 2 times, most recently from 3203126 to 44922a8 Compare July 20, 2020 14:51
@guggero guggero requested a review from Roasbeef September 7, 2020 10:16
@guggero guggero mentioned this pull request Sep 7, 2020
Merged
wpaulino
wpaulino reviewed Sep 14, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Will begin playing around with it locally and report any issues.

Comment thread lnrpc/walletrpc/walletkit.proto Outdated
Comment thread lnrpc/walletrpc/psbt.go Outdated
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What @Roasbeef was referring to was to defer at the level of the caller of lockInputs, as an error can occur in some other method after the fact and the inputs wouldn't be released. There isn't a method that's called after lockInputs that returns an error at the moment, but it's probably still worth making the change to prevent any potential bugs in the future.

@guggero guggero force-pushed the psbt-signing branch 3 times, most recently from 0412ffd to 1e460b7 Compare September 16, 2020 13:51
@wpaulino wpaulino self-requested a review September 17, 2020 22:43
cfromknecht
cfromknecht reviewed Sep 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guggero nice work! lot of good stuff in here :)

Comment thread lnrpc/walletrpc/walletkit_server.go Outdated
Comment thread lnrpc/walletrpc/psbt.go Outdated
Copy link
Copy Markdown
Contributor

@cfromknecht cfromknecht Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another option would be to make a LeaseOutputs and ReleaseOutputs that lock all of them atomically

Comment thread cmd/lncli/walletrpc_active.go Outdated
Comment thread lntest/itest/lnd_psbt_test.go Outdated
@guggero guggero requested a review from cfromknecht September 24, 2020 09:20
Roasbeef
Roasbeef approved these changes Oct 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I think this is missing is some light doc updates, but that's totally non-blocking, and this PR has been in stasis for quite a while.

LGTM 🎨

Comment thread cmd/lncli/walletrpc_active.go Outdated
@guggero
Copy link
Copy Markdown
Collaborator Author

guggero commented Oct 1, 2020 •
edited
Loading

DON'T MERGE, just discovered a bug in the fee estimation if more than one input is selected (good thing I started writing the docs for this and coming up with useful examples 😅 )

EDIT: Fix is up: btcsuite/btcwallet#721.

@guggero
Copy link
Copy Markdown
Collaborator Author

guggero commented Oct 1, 2020

Added some documentation with examples and fixed the change amount bug.

wpaulino
wpaulino approved these changes Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@wpaulino wpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@wpaulino
Copy link
Copy Markdown
Contributor

wpaulino commented Oct 2, 2020

@guggero needs a rebase, but it should be good to merge once addressed.

guggero added 10 commits October 3, 2020 10:34
@guggero
mod: update to latest btcwallet version
8e0a162
@guggero
chanfunding: use util functions from psbt package
936a838
@guggero
btcwallet: use new base wallet methods
9f5f98e
@guggero
lnwallet+mock: add new PSBT methods
f947576
@guggero
lnrpc+walletrpc: add RPCs for new PSBT methods
6229609
@guggero
walletrpc: disallow locking with internal ID
9a06335 
The internal lock ID that the wallet kit subserver uses to lock inputs
for itself shouldn't be allowed to be used when locking inputs manually
over the RPC.
@guggero
lncli: add new PSBT wallet commands
c206d06
@guggero
itest: use require library
f114fb3 
We rewrite the test to use the require library to make it a
bit more condensed.
@guggero
itest: use new PSBT functions for funding flow
eb280fd 
Now that we have all functions that we need to complete the whole
PSBT channel funding flow, we change the itest to use Dave's wallet
to fund the channel from Carol to Dave through a PSBT.
@guggero
docs: update PSBT documentation
84dfed3
@guggero guggero merged commit f8e3b41 into lightningnetwork:master Oct 3, 2020
@guggero guggero deleted the psbt-signing branch October 3, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Roasbeef Roasbeef Roasbeef approved these changes

@cfromknecht cfromknecht Awaiting requested review from cfromknecht

+1 more reviewer

@wpaulino wpaulino wpaulino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement Improvements to existing features / behaviour psbt rpc Related to the RPC interface v0.12 wallet The wallet (lnwallet) which LND uses

Projects

None yet

Milestone

0.12.0

4 participants

@guggero @Roasbeef @wpaulino @cfromknecht