htlcswitch: add htlc interceptor failure control#6177
htlcswitch: add htlc interceptor failure control#6177Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
joostjager
force-pushed
the
interceptor-failures
branch
from
e67c7c8 to
44a3467
Compare
|
the |
|
Yes that is indeed the use case. The htlc interceptor is basically a 'link-over-grpc'. |
joostjager
force-pushed
the
interceptor-failures
branch
from
44a3467 to
7112669
Compare
That's great, I think this is a superior approach to #4785 |
joostjager
force-pushed
the
interceptor-failures
branch
from
7112669 to
e328acd
Compare
champo
left a comment
champo
left a comment
There was a problem hiding this comment.
Love this, makes the interceptor way more useful.
lnrpc/routerrpc/router.proto
Outdated
There was a problem hiding this comment.
why did you choose to scope this to malformed htlc errors? As written, it would be easy to add other cases like CodeChannelDisabled, CodeTemporaryChannelFailure, CodePermanentChannelFailure which would be useful too.
There was a problem hiding this comment.
This is all that I needed for my purpose. It could be generalized, but then also all the failure message parameters need to be marshaled over rpc? Or would you do a hybrid where you only specify the code and lnd tries to fill in the message parameters?
There was a problem hiding this comment.
The ones I was thinking about are either very similar to existing cases or have no parameters. In any case, none of this needs to be implemented now. I was mostly wondering why the thight scope for the semantics.
There was a problem hiding this comment.
Reworked the PR to widen the scope.
joostjager
force-pushed
the
interceptor-failures
branch
4 times, most recently
from
c251faa to
7284033
Compare
carlaKC
left a comment
carlaKC
left a comment
There was a problem hiding this comment.
Great addition to the interceptor!
joostjager
force-pushed
the
interceptor-failures
branch
3 times, most recently
from
e345400 to
3ba4f33
Compare
|
@joostjager, remember to re-request review from reviewers when ready |
bhandras
left a comment
bhandras
left a comment
There was a problem hiding this comment.
LGTM, just a few nits 👍
joostjager
force-pushed
the
interceptor-failures
branch
2 times, most recently
from
df1dad5 to
db41e72
Compare
joostjager
force-pushed
the
interceptor-failures
branch
from
db41e72 to
e2b56f2
Compare
| code = lnwire.CodeInvalidOnionVersion | ||
|
|
||
| // Default to TemporaryChannelFailure. | ||
| case 0, lnrpc.Failure_TEMPORARY_CHANNEL_FAILURE: |
There was a problem hiding this comment.
Interesting way to override the default here programatically...🤔
7 participants
This PR extends the HTLC interceptor API so that users can control the exact failure message that is returned to the sender of the payment.