signrpc: add Schnorr signatures to sign and verify message #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@guggero Great. Will test the code when it's done. |
Roasbeef
approved these changes
Jul 14, 2022
| "signature: %v", err) | ||
| } | ||
|
|
||
| digest := chainhash.HashB(in.Msg) |
There was a problem hiding this comment.
Doesn't this need to conditionally double hash based on the msg expectation?
There was a problem hiding this comment.
I don't think that's necessary. The double hashing is only needed by the remote signing setup (for signing a channel or node announcement) but we seem to be verifying it in a different way (not through the signer interface).
guggero
force-pushed
the
sign-schnorr-tweaked
branch
from
99fd293
to
c6fbf8a
Compare
guggero
force-pushed
the
sign-schnorr-tweaked
branch
from
c6fbf8a
to
98abaf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #6663.
Fixes #6656.
Thank you @ErikEk for starting this, needed to add an additional feature (Taproot key tweak), so I took over the PR.
All commits are still properly attributed to the original author.