Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Send to route rpc #188 #747
At the moment
This is my first PR, feedback welcomed.
A timelock delta of 9 is the default value for the final hop assuming that they don't specify anything in the invoice. Our default policy is to use a value of 144, hence the check in link.go (which isn't hard coded but part of the current policy and can be changed on a per-channel basis). So seems like the solution here is to take a
Yeah, so it would be an optional argument. There's an "assumed" default of 9 blocks within the network. In scenarios where the use case is to pipe the result through
The changes to
rpcserver are a bit intrusive I'm afraid. Should be possible to simplify significantly?
referenced this pull request
Apr 23, 2018
No problem. Do what's easiest for you! Will do a clean review of the new set. On Apr 26, 2018 7:02 PM, "Tasuku Nakamura" <firstname.lastname@example.org> wrote: @Roasbeef <https://github.com/Roasbeef> Rebasing rpcserver.go has been giving me a headache. Do you mind if I delete some commits and rework them? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#747 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA87LiPUorisxDirQxpNYXCzZHau3vLXks5tsnwvgaJpZM4R_0jJ> .