lnrpc: return meaningful response instead of empty one by guggero · Pull Request #7762 · lightningnetwork/lnd

guggero · 2023-06-13T12:05:05Z

Change Description

Replaces #7476.
Fixes #7440.

An empty response looks confusing to new users on the command line, since it just prints:

{
}

Instead we return at least a "Status" field that contains a message about what happened.

coderabbitai · 2024-11-04T12:22:06Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

ellemouton

Nice! some comments

yyforyongyu

Thanks for this PR! I also find it very useful to have explicit messages in the response💯

yyforyongyu · 2024-11-06T03:58:09Z


 ## RPC Updates

+* Some RPCs that previously just returned an empty response message now at least


I wonder if there's an easy way to let the existing users know which responses are changed 🤔

No easy way, no. But added a manual summary to the release notes.

Very nice thanks!

The sendcustom and subscribecustom sub commands weren't correctly categorized and didn't have any usage text set.

guggero · 2024-11-06T14:31:11Z

Thanks for the reviews and sorry for the rookie CI mistakes. Should all be fixed now but will wait with re-requesting review until CI is green.

ellemouton

LGTM! 🔥 💎

yyforyongyu

LGTM⛵️

yyforyongyu · 2024-11-07T17:57:56Z

-	Name: "sendcustom",
+	Name:     "sendcustom",
+	Category: "Peers",
+	Usage:    "Send a custom p2p wire message to a peer",


yyforyongyu · 2024-11-07T17:58:12Z


 ## RPC Updates

+* Some RPCs that previously just returned an empty response message now at least


Very nice thanks!

Roasbeef added this to the v0.17.1 milestone Jul 4, 2023

saubyk added P1 MUST be fixed or reviewed P2 should be fixed if one has time and removed P1 MUST be fixed or reviewed labels Aug 8, 2023

saubyk modified the milestones: High Priority, Medium Priority Aug 8, 2023

saubyk added the rpc Related to the RPC interface label Aug 8, 2023

saubyk removed this from the Medium Priority milestone Aug 8, 2023

guggero mentioned this pull request Nov 28, 2023

neutrino remove sweeptx #7800

Merged

7 tasks

This was referenced Feb 5, 2024

wtclient: add DeactivateTower and TerminateSession commands #8239

Merged

[bug]: can't bump fee of a coop closed channel #8391

Open

guggero mentioned this pull request Apr 17, 2024

[bug]: verifychanbackup indicates a good backup with empty json response #7440

Closed

guggero force-pushed the empty-resp branch from 07ff4b9 to 9298f5c Compare November 4, 2024 12:21

guggero requested a review from ellemouton November 4, 2024 12:22

ellemouton reviewed Nov 5, 2024

View reviewed changes

Comment thread itest/lnd_channel_backup_test.go

Comment thread itest/lnd_channel_backup_test.go

Comment thread chanbackup/recover.go

Comment thread itest/lnd_channel_backup_test.go Outdated

yyforyongyu reviewed Nov 6, 2024

View reviewed changes

guggero added 7 commits November 6, 2024 15:30

channeldb+rpcserver: return number of deleted payments

15a5fe7

chanbackup+rpcserver+server: return number of recovered channels

d8c920f

lnrpc+rpcserver: return meaningful responses instead of empty

45e13ce

itest: add tests for new backup responses

26216f7

walletrpc: return meaningful responses instead of empty

d89ea2d

cmd/lncli: print new status responses to CLI

870e845

rpcserver: fix formatting and grammar issues

0e5c724

guggero force-pushed the empty-resp branch from 9298f5c to 5673dab Compare November 6, 2024 14:30

guggero added 2 commits November 6, 2024 15:30

cmd/commands: fix custom message commands

4bf2469

The sendcustom and subscribecustom sub commands weren't correctly categorized and didn't have any usage text set.

docs: add release notes

5673dab

guggero requested review from ellemouton and yyforyongyu November 6, 2024 15:26

ellemouton approved these changes Nov 7, 2024

View reviewed changes

yyforyongyu approved these changes Nov 7, 2024

View reviewed changes

guggero merged commit 0899077 into lightningnetwork:master Nov 7, 2024

guggero deleted the empty-resp branch November 7, 2024 18:14


		## RPC Updates

		* Some RPCs that previously just returned an empty response message now at least

Uh oh!

Conversation

guggero commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Description

Uh oh!

coderabbitai Bot commented Nov 4, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

yyforyongyu Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

guggero Nov 6, 2024

Choose a reason for hiding this comment

Uh oh!

yyforyongyu Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

guggero commented Nov 6, 2024

Uh oh!

ellemouton left a comment

Choose a reason for hiding this comment

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

yyforyongyu Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

yyforyongyu Nov 7, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guggero commented Jun 13, 2023 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)