[1/7] lnwire: add new Gossip 1.75 messages by ellemouton · Pull Request #8044 · lightningnetwork/lnd

ellemouton · 2023-09-29T10:18:57Z

This is the first step towards the Gossip 1.75 epic

In this PR, the definitions for the new gossip messages defined in the
taproot-gossip proposal are implemented. This includes:

announcement_signatures_2
channel_announcement_2
channel_update_2

Various updates are also made to some existing messages such as channel_ready and gossip_timestamp_range

I expect there to still be a few updates to these messages as the proposal progresses

Crypt-iQ

looks good, just a few questions

Roasbeef

Nice work! Need to cross ref with the spec, but the main comment is using tlv.RecordT in place of some of the new structs and helper functions.

Roasbeef

LGTM 🌊

Should be g2g after a linter fix:

Error: lnwire/interfaces.go:58:1: directive `//nolint:interfacebloat` is unused for linter "interfacebloat" (nolintlint)

yyforyongyu

Thanks for the effort in writing all those tests🙏 I think it's good to go, just a few nits. Will refresh the specs and post questions in the following PRs, if any.

yyforyongyu · 2024-09-18T12:47:30Z

+		}
+
+		keys = append(keys, bitcoinKey1, bitcoinKey2)
+	} else {


Q: what if only one of the keys is set, like bitcoinKey1 is set but not bitcoinKey2?

it will then fall to the else branch below which will fetch the on-chain script.
ie, we dont explicitly need to not allow that case I dont think. It could maybe be a valid future message potentially.

In preparation for adding a new message, AnnounceSignatures2 along with an AnnounceSignatures interface, we rename the existing message to AnnounceSignatures1.

In preparation for adding the new ChannelAnnouncement2 message along with a ChannelAnnouncement interface, we rename the existing message to ChannelAnnouncement1.

In preparation for adding a new ChannelUpdate2 message and a ChannelUpdate interface, we rename the existing message to ChannelUpdate1.

In preparation for Gossip 1.75, we add new TLV's to the `ChannelReady` message. Namely: `AnnouncementBitcoinNonce` and `AnnouncementNodeNonce`. These will be used to exchange nones required for producing the partial signature to be send in the `AnnouncementSignatures2` message. The type numbers for these new fields are even because if they are set, then a peer is expecting its peer to understand gossip 1.75 and the new fields.

Add new FirstBlockHeight and BlockRange TLV fields to the GossipTimestampRange message. This will be used to query for Gossip 1.75 messages which are timestamped using block height instead of Unix timestamps.

Add a AnnounceSignatures interface and ensure that AnnounceSignatures1 implements it.

So that it can be re-used elsewhere.

This commit makes an lnwallet.BlockChainIO available to the gossiper and uses it to construct a helper that can be used to fetch the pk script for a given SCID. This will be used for channel announcement verification in an upcoming commit.

from the graph package.

Add a new ChannelAnnouncement interface and ensure that ChannelAnnouncement1 implements it.

In this commit, a new ChannelUpdate interface is added and ChannelUpdate1 is made to implement the new interface.

And ensure that it implements the AnnounceSignatures interface.

And ensure that it implements the ChannelAnnouncement interface.

This commit adds the MsgHash helper function which can be used to calculate the digest of a message to be signed using schnorr signatures.

Add the new ChannelUpdate2 message and ensure that it implements the ChannelUpdate interface.

ellemouton · 2024-09-18T14:21:45Z

Thanks for the review @Roasbeef & @yyforyongyu 🔈

ellemouton marked this pull request as draft September 29, 2023 10:19

ellemouton force-pushed the g175Messages branch from 610fad0 to 20970c8 Compare September 29, 2023 11:09

saubyk added this to the v0.18.0 milestone Oct 3, 2023

ellemouton force-pushed the g175Messages branch from 20970c8 to 9c03cfa Compare October 10, 2023 13:08

ellemouton mentioned this pull request Oct 10, 2023

[WIP] multi: use ChannelAnnouncement2 to advertise Taproot Channels #8079

Closed

ellemouton added the gossip label Oct 10, 2023

saubyk linked an issue Oct 12, 2023 that may be closed by this pull request

[epic]: Gossip 1.75 #7961

Closed

21 tasks

ellemouton force-pushed the g175Messages branch from 9c03cfa to 0491785 Compare October 26, 2023 12:19

ellemouton mentioned this pull request Oct 26, 2023

[epic]: Gossip 1.75 #7961

Closed

21 tasks

ellemouton force-pushed the g175Messages branch 2 times, most recently from f06fad6 to ba60010 Compare October 26, 2023 13:48

saubyk assigned ellemouton Oct 28, 2023

ellemouton force-pushed the g175Messages branch 4 times, most recently from 3647e34 to 4074a8c Compare November 9, 2023 11:43

ellemouton changed the title ~~lnwire: add new Gossip 1.75 messages~~ [1/n] lnwire: add new Gossip 1.75 messages Nov 9, 2023

ellemouton marked this pull request as ready for review November 9, 2023 11:54

ellemouton mentioned this pull request Nov 9, 2023

[2/7] channeldb: add new types and interfaces for gossip 1.75 #8164

Closed

ellemouton force-pushed the g175Messages branch from 4074a8c to 0695472 Compare November 16, 2023 15:12

ellemouton force-pushed the g175Messages branch 2 times, most recently from b0d6a0e to 7d3db71 Compare December 4, 2023 10:25

ellemouton removed a link to an issue Dec 5, 2023

[epic]: Gossip 1.75 #7961

Closed

21 tasks

ellemouton force-pushed the g175Messages branch from 7d3db71 to 6ee21d7 Compare December 6, 2023 13:19

ellemouton changed the title ~~[1/n] lnwire: add new Gossip 1.75 messages~~ [1/7] lnwire: add new Gossip 1.75 messages Dec 6, 2023

saubyk requested a review from Crypt-iQ December 6, 2023 17:51

Crypt-iQ reviewed Dec 13, 2023

View reviewed changes

Comment thread lnwire/lnwire_test.go

Comment thread lnwire/channel_update_2.go Outdated

Comment thread lnwire/channel_ready.go Outdated

yyforyongyu self-requested a review December 25, 2023 10:28

Roasbeef requested changes Jan 5, 2024

View reviewed changes

ellemouton force-pushed the g175Messages branch from 6ee21d7 to 53084cb Compare January 10, 2024 13:45

Roasbeef approved these changes Sep 16, 2024

View reviewed changes

yyforyongyu approved these changes Sep 18, 2024

View reviewed changes

ellemouton added 22 commits September 18, 2024 16:13

multi: rename AnnounceSignatures to AnnounceSignatures1

05d76b6

In preparation for adding a new message, AnnounceSignatures2 along with an AnnounceSignatures interface, we rename the existing message to AnnounceSignatures1.

multi: rename ChannelAnnouncement to ChannelAnnouncment1

bb44efa

In preparation for adding the new ChannelAnnouncement2 message along with a ChannelAnnouncement interface, we rename the existing message to ChannelAnnouncement1.

multi: rename ChannelUpdate to ChannelUpdate1

60f331e

In preparation for adding a new ChannelUpdate2 message and a ChannelUpdate interface, we rename the existing message to ChannelUpdate1.

lnwire: add FirstBlock and BlockRange to GossipTimestampRange

df65b7c

Add new FirstBlockHeight and BlockRange TLV fields to the GossipTimestampRange message. This will be used to query for Gossip 1.75 messages which are timestamped using block height instead of Unix timestamps.

lnwire: add AnnounceSignatures interface

f230e2c

Add a AnnounceSignatures interface and ensure that AnnounceSignatures1 implements it.

graph+lnwallet: move FetchTx logic to lnwallet

9be84c1

So that it can be re-used elsewhere.

multi: move channel announcement validation to netann

615db1f

from the graph package.

lnwire: add a ChannelAnnouncement interface

e07d235

Add a new ChannelAnnouncement interface and ensure that ChannelAnnouncement1 implements it.

multi: move ChannelUpdate validate methods to netann

7bbf896

lnwire: lnwire: add a ChannelUpdate interface

34e9ee1

In this commit, a new ChannelUpdate interface is added and ChannelUpdate1 is made to implement the new interface.

netann: let ValidateChannelAnn take the new interface

35d0c61

netann: let ChannelUpdate validate methods take in the new interface

ced88a9

lnwire: add AnnounceSignatures2 message

0b4e5a0

And ensure that it implements the AnnounceSignatures interface.

lnwire: make RawFeatureVector a Record producer

66302ce

lnwire: add ChannelAnnouncement2 message

a438eb3

And ensure that it implements the ChannelAnnouncement interface.

netann: add MsgHash helper

5fc1da3

This commit adds the MsgHash helper function which can be used to calculate the digest of a message to be signed using schnorr signatures.

netann: validation and verification funcs for ChannelAnnouncement2

21c9ef8

lnwire: add ChannelUpdate2

580c104

Add the new ChannelUpdate2 message and ensure that it implements the ChannelUpdate interface.

netann: add chan update 2 validate and verify funcs

a62201b

docs: update release notes

077273e

ellemouton force-pushed the g175Messages branch from a826e6e to 077273e Compare September 18, 2024 14:20

Roasbeef merged commit 13a7bec into lightningnetwork:master Sep 18, 2024

ellemouton deleted the g175Messages branch September 19, 2024 02:13

This was referenced Oct 18, 2024

TABConf 6 Socratic Session: Lightning Protocol Development TriangleBitDevs/TriangleBitDevs.github.io#28

Closed

Socratic Session: Lightning BOLT Spec and Implementation Updates TABConf/6.tabconf.com#148

Closed

Conversation

ellemouton commented Sep 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Crypt-iQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Roasbeef left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Roasbeef left a comment

Choose a reason for hiding this comment

Uh oh!

yyforyongyu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yyforyongyu Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

ellemouton Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ellemouton commented Sep 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ellemouton commented Sep 29, 2023 •

edited

Loading