cmd: allow deterministic macaroon derivation with lncli#9172
Merged
guggero merged 4 commits intoOct 15, 2024
Conversation
ellemouton
approved these changes
Oct 14, 2024
Collaborator
ellemouton
left a comment
ellemouton
left a comment
There was a problem hiding this comment.
tACK, LGTM - very nice. Super useful 🚀
ViktorT-11
approved these changes
Oct 14, 2024
Collaborator
ViktorT-11
left a comment
ViktorT-11
left a comment
There was a problem hiding this comment.
tACK LGTM, once the linting CI error has been addressed! Thanks a lot for this 🚀🔥!
I've tested this in combination with #8754, and can confirm that I've created a setup where the signer & watch-only node doesn't need to be restarted during the init 🚀! Thanks a lot :)
This commit adds a new --mac_root_key flag to both the lncli create and lncli createwatchonly commands that allows the user to specify the macaroon root key that should be used when creating the macaroon database on wallet initialization. This allows for deterministic wallet initialization and baking of macaroons before the wallet is initialized.
guggero
force-pushed
the
initwallet-mac-root-key
branch
from
b506902 to
fcb21df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--mac_root_keyflag to thelncli createandlncli createwatchonlycommands that allow the deterministic initialization of the macaroon root key store.That allows macaroons to be baked (with a new
--root_keyflag of thelncli bakemacarooncommand) before a node is even started.This will be especially useful in combination with the new reverse remote signer setup in #8754.