invoicesrpc: remove direct access to ChannelGraph pointer#9516
invoicesrpc: remove direct access to ChannelGraph pointer#9516guggero merged 1 commit intolightningnetwork:masterfrom
Conversation
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
yyforyongyu
left a comment
There was a problem hiding this comment.
LGTM - the itest falire is a flake and should be fixed by #9501.
Let the invoicerpc server define an interface describing what it needs from a graph source.
Use this interface instead of a direct pointer to the ChannelGraph
part of #9494