macaroons: ip range constraint#9546
Merged
guggero merged 4 commits intoMar 14, 2025
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
hieblmi
force-pushed
the
macaroon-ip-cidr-constraint
branch
from
0b78ea0 to
b6ecf4d
Compare
hieblmi
force-pushed
the
macaroon-ip-cidr-constraint
branch
from
b6ecf4d to
ae12030
Compare
guggero
approved these changes
Mar 7, 2025
Collaborator
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Very nice feature! LGTM 🎉
hieblmi
force-pushed
the
macaroon-ip-cidr-constraint
branch
2 times, most recently
from
263d9db to
f36dc2d
Compare
Collaborator
Author
|
Thanks for the review @guggero, I've addressed all your comments. |
guggero
approved these changes
Mar 11, 2025
hieblmi
force-pushed
the
macaroon-ip-cidr-constraint
branch
from
f36dc2d to
dca2eb2
Compare
yyforyongyu
reviewed
Mar 13, 2025
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
Looking good, just need to fix the linter.
| // check. | ||
| pr, ok := peer.FromContext(ctx) | ||
| if !ok { | ||
| return fmt.Errorf("unable to get peer info from " + |
Member
There was a problem hiding this comment.
nit: use errors.New to avoid some bot-created PRs in the future to change it again 😂
|
|
||
| if !ipNet.Contains(net.ParseIP(peerAddr)) { | ||
| msg := "macaroon locked to different IP range" | ||
| return fmt.Errorf(msg) |
Member
There was a problem hiding this comment.
nit: same here re errors.New
hieblmi
force-pushed
the
macaroon-ip-cidr-constraint
branch
from
dca2eb2 to
bef0268
Compare
yyforyongyu
approved these changes
Mar 14, 2025
Member
yyforyongyu
left a comment
yyforyongyu
left a comment
There was a problem hiding this comment.
LGTM👍 Confirmed the CI failure is a flake fixed in #9600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upon user request this PR aims to add an
ip_rangeflag tolncli constrainmacaroonsubcommand.The user intention is to constrain access to a resource to a certain IP range. Currently, only specific IPs can be tied to access resources via a macaroon.