lntest: wait for ChanUpdate req to be fully processed before sending another - #9574
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are limited to specific labels. 🏷️ Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
ellemouton
force-pushed
the
fixWatcherPanic
branch
from
March 3, 2025 15:32
1a74ba4 to
27b5c9a
Compare
…another Before this commit, it was possible for a request to be sent on the `chanWatchRequests` channel in `WaitForChannelPolicyUpdate` and then for the `ticker.C` case to select _before_ the `eventChan` select gets triggered when the `topologyWatcher` closes the `eventChan` in its call to `handlePolicyUpdateWatchRequest`. This could lead to a "close of a closed channel" panic. To fix this, this commit ensures that we only move on to the next iteration of the select statement in `WaitForChannelPolicyUpdate` once the request sent on `chanWatchRequests` has been fully handled.
ellemouton
force-pushed
the
fixWatcherPanic
branch
from
March 3, 2025 15:53
27b5c9a to
57c6c23
Compare
yyforyongyu
approved these changes
Mar 5, 2025
yyforyongyu
left a comment
yyforyongyu
left a comment
Member
There was a problem hiding this comment.
Confirmed the itest failure is a flake.
bhandras
self-requested a review
March 6, 2025 12:42
bhandras
approved these changes
Mar 6, 2025
Collaborator
Author
|
cc @guggero for override merge 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, it was possible for a request to be sent on the
chanWatchRequestschannel inWaitForChannelPolicyUpdateand then for theticker.Ccase to select before theeventChanselect gets triggered when thetopologyWatchercloses theeventChanin its call tohandlePolicyUpdateWatchRequest. This could lead to a "close of a closed channel" panic.To fix this, this commit ensures that we only move on to the next iteration of the select statement in
WaitForChannelPolicyUpdateonce the request sent onchanWatchRequestshas been fully handled.See this build for an instance of where this panic was triggered.