Skip to content

config: rename skip-sql-invoice-migration to skip-native-sql-migration#9606

Merged
bhandras merged 1 commit into
lightningnetwork:masterfrom
bhandras:skip-migration-rename
Mar 18, 2025
Merged

config: rename skip-sql-invoice-migration to skip-native-sql-migration#9606
bhandras merged 1 commit into
lightningnetwork:masterfrom
bhandras:skip-migration-rename

Conversation

@bhandras

Copy link
Copy Markdown
Collaborator

In future releases we will use this flag to make potentially failing kv to native SQL migrations optional. For this reason it is better to rename it to avoid confusion.

@bhandras bhandras added the config Parameters/arguments/config file related issues/PRs label Mar 17, 2025
@bhandras bhandras self-assigned this Mar 17, 2025
@coderabbitai

coderabbitai Bot commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)
  • llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

In future releases we will use this flag to make potentially failing kv
to native SQL migrations optional. For this reason it is better to
rename it to avoid confusion.
@bhandras
bhandras force-pushed the skip-migration-rename branch from 97c1205 to 5559595 Compare March 17, 2025 15:45
@saubyk saubyk moved this to In Progress in lnd v0.19 Mar 17, 2025

@ziggie1984 ziggie1984 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we will only have one global flag and will not separate between different submodules (invoices, payments) from now on ?

@ellemouton ellemouton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bhandras
bhandras merged commit 3e8339c into lightningnetwork:master Mar 18, 2025
@github-project-automation github-project-automation Bot moved this from In Progress to Done in lnd v0.19 Mar 18, 2025
@bhandras

Copy link
Copy Markdown
Collaborator Author

So we will only have one global flag and will not separate between different submodules (invoices, payments) from now on ?

Yes, this is a prerequisite for future migrations, as we don’t want to require a flag for all new migrations. Additionally, we want to avoid a scenario where other KV tables are migrated while invoices are accidentally skipped.

@bhandras
bhandras deleted the skip-migration-rename branch March 18, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Parameters/arguments/config file related issues/PRs

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants