refactor: use maps.Copy for cleaner map handling by xinhangzhou · Pull Request #9630 · lightningnetwork/lnd

xinhangzhou · 2025-03-24T09:14:56Z

Change Description

Use the built-in methods from the standard library to simplify the code.

The same as btcsuite/btcd#2343

Steps to Test

Steps for reviewers to follow to test the change.

Pull Request Checklist

Testing

Your PR passes all CI checks.
Tests covering the positive and negative (error paths) are included.
Bug fixes contain tests triggering the bug to prevent regressions.

Code Style and Documentation

The change is not insubstantial. Typo fixes are not accepted to fight bot spam.
The change obeys the Code Documentation and Commenting guidelines, and lines wrap at 80.
Commits follow the Ideal Git Commit Structure.
Any new logging statements use an appropriate subsystem and logging level.
Any new lncli commands have appropriate tags in the comments for the rpc in the proto file.
There is a change description in the release notes, or [skip ci] in the commit message for small changes.

📝 Please see our Contribution Guidelines for further guidance.

coderabbitai · 2025-03-24T09:15:04Z

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

bhandras · 2025-03-24T09:17:41Z

-	for peerPub, count := range counts {
-		a.peerCounts[peerPub] = count
-	}
+	maps.Copy(a.peerCounts, counts)


Have you looked into how such refactor could be applied to the whole codebase perhaps?

Yes, I conducted a check, and the other several that seem to meet the criteria are all of slice type. Currently, I can find these few instances.

I think there are a couple more. Perhaps would you mind examining the output of this program and fix those too for completeness? https://github.com/bhandras/mapsearch

Great! The program you provided is very useful!

There's still a few left afaict, could you please add those too?

bhandras · 2025-03-24T12:42:43Z

-	for peerPub, count := range counts {
-		a.peerCounts[peerPub] = count
-	}
+	maps.Copy(a.peerCounts, counts)


I think there are a couple more. Perhaps would you mind examining the output of this program and fix those too for completeness? https://github.com/bhandras/mapsearch

bhandras · 2025-03-24T12:43:21Z

Also could you please make sure that you update the change log?

xinhangzhou · 2025-03-24T14:25:36Z

Also could you please make sure that you update the change log?

Thank you for your guidance. I have replaced everything, and please review it again. However, I couldn't find the changelog file.

bhandras · 2025-03-24T14:37:13Z

Also could you please make sure that you update the change log?

Thank you for your guidance. I have replaced everything, and please review it again. However, I couldn't find the changelog file.

The changelog is here: https://github.com/lightningnetwork/lnd/blob/master/docs/release-notes/release-notes-0.19.0.md

xinhangzhou · 2025-03-24T14:47:32Z

Also could you please make sure that you update the change log?

Thank you for your guidance. I have replaced everything, and please review it again. However, I couldn't find the changelog file.

The changelog is here: https://github.com/lightningnetwork/lnd/blob/master/docs/release-notes/release-notes-0.19.0.md

Thanks. Add the changelog. Please review again.

xinhangzhou · 2025-03-24T14:51:15Z

Sorry to bother you, but there's another thing I would like to consult you about: I proposed an optimization using max/min to simplify the code at #9632. Should I submit two PRs as I am now, or should I merge it into one with the current one?

guggero

Thanks for the change.

Signed-off-by: xinhangzhou <shuangcui@aliyun.com>

bhandras reviewed Mar 24, 2025

View reviewed changes

bhandras requested changes Mar 24, 2025

View reviewed changes

xinhangzhou changed the title ~~refactor: use map.Copy for cleaner map handling~~ refactor: use maps.Copy for cleaner map handling Mar 24, 2025

xinhangzhou force-pushed the master branch from cfaa6fc to 5f51cc1 Compare March 24, 2025 14:24

xinhangzhou force-pushed the master branch from 5f51cc1 to 519e47c Compare March 24, 2025 14:47

guggero reviewed Mar 24, 2025

View reviewed changes

Comment thread lnwire/custom_records.go Outdated

Comment thread lnwire/custom_records.go

guggero mentioned this pull request Mar 24, 2025

refactor: use map.Copy for cleaner map handling btcsuite/btcd#2343

Merged

1 of 7 tasks

bhandras reviewed Mar 24, 2025

View reviewed changes

Comment thread docs/release-notes/release-notes-0.19.0.md Outdated

refactor: use maps.Copy for cleaner map handling

b7e3c20

Signed-off-by: xinhangzhou <shuangcui@aliyun.com>

xinhangzhou force-pushed the master branch from 519e47c to b7e3c20 Compare March 24, 2025 17:20

guggero self-requested a review March 24, 2025 17:47

guggero approved these changes Mar 27, 2025

View reviewed changes

saubyk assigned xinhangzhou Mar 27, 2025

yyforyongyu approved these changes Mar 28, 2025

View reviewed changes

bhandras approved these changes Mar 28, 2025

View reviewed changes

bhandras merged commit b6cf1bc into lightningnetwork:master Mar 28, 2025

Conversation

xinhangzhou commented Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Description

Steps to Test

Pull Request Checklist

Testing

Code Style and Documentation

Uh oh!

coderabbitai Bot commented Mar 24, 2025

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

bhandras Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

xinhangzhou Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

bhandras Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xinhangzhou Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

bhandras Mar 24, 2025

Choose a reason for hiding this comment

Uh oh!

bhandras Mar 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bhandras commented Mar 24, 2025

Uh oh!

xinhangzhou commented Mar 24, 2025

Uh oh!

bhandras commented Mar 24, 2025

Uh oh!

xinhangzhou commented Mar 24, 2025

Uh oh!

xinhangzhou commented Mar 24, 2025

Uh oh!

guggero left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

xinhangzhou commented Mar 24, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

bhandras Mar 24, 2025 •

edited

Loading

bhandras Mar 24, 2025 •

edited

Loading