sweep: return all inputs in PendingSweeps

[yyforyongyu]

Previously when calling PendingSweeps, if the outputs being swept have a locktime in the future, they will be filtered out. This is now changed such that all outputs registered in the sweeper will be returned in the RPC response regardless of their locktime, which enables users to plan ahead about upcoming sweeps and implement customized aggregation logic.

A new field, MaturityHeight, has been added to PendingSweep to show the absolute locktime value.

Thanks @Liongrass for the feedback!

[coderabbitai]

Important

Review skipped

Auto reviews are limited to specific labels.

🏷️ Labels to auto review (1)

• llm-review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ziggie1984]

Looks good, had some nits and a question.

[ziggie1984]

LGTM

[guggero]

Just a drive-by question: Do we know how many inputs a sweep has at any given time? Exposing the number of target inputs (e.g. the inputs we want to sweep) and the number of sponsoring inputs (e.g. the inputs purely added to pay for fees) would be quite useful to have in the TAP integration tests. So if they're easy to add, perhaps we could do that in this PR as well.
If it's super involved, don't worry and ignore this request, we can always look up the TX with an additional step.

[yyforyongyu]

Do we know how many inputs a sweep has at any given time?

Yes we do know that internally in the sweeper, before we aggregate them and potentially add more wallet inputs.

Exposing the number of target inputs (e.g. the inputs we want to sweep) and the number of sponsoring inputs (e.g. the inputs purely added to pay for fees) would be quite useful to have in the TAP integration tests. So if they're easy to add, perhaps we could do that in this PR as well.

I think we need this too, to make fee bumping a bit easier. This is the 7th item in #8680, which can be a bit involved as we need to change the sweeper to remember all the input sets (atm it's created over-the-fly), then maybe a new RPC to return that info. But yeah def will find time to add it.

[Roasbeef]

LGTM 🧣