added conf_target and sat_per_byte to closeallchannels#990
Merged
Roasbeef merged 1 commit intolightningnetwork:masterfrom Jun 4, 2019
Merged
added conf_target and sat_per_byte to closeallchannels#990Roasbeef merged 1 commit intolightningnetwork:masterfrom
Roasbeef merged 1 commit intolightningnetwork:masterfrom
Conversation
meshcollider
added
rpc
michael1011
force-pushed
the
master
branch
2 times, most recently
from
070cba4 to
23c4f32
Compare
Contributor
wpaulino
reviewed
May 1, 2018
Contributor
wpaulino
left a comment
wpaulino
left a comment
There was a problem hiding this comment.
Thanks for the PR! The changes look good to me other than some minor nits. Could you also squash both commits into one?
Contributor
There was a problem hiding this comment.
Could you rephrase this to specify that these are the closing transactions of the channels being closed?
michael1011
force-pushed
the
master
branch
2 times, most recently
from
4b715fb to
c998bd2
Compare
Contributor
Author
|
Sorry for responding so late. I completely forgot about this pr 😕 |
Roasbeef
added
P3
wpaulino
reviewed
Feb 2, 2019
Contributor
|
Oldie but goodie. @michael1011 Can you give it a rebase? 😄 |
Contributor
Author
|
Done @halseth |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the command line flags
conf_targetandsat_per_byteto the commandcloseallchannels.Was requested by joaoalmeida on Slack.