Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conf_target and sat_per_byte to closeallchannels #990

Merged
merged 1 commit into from Jun 4, 2019

Conversation

@michael1011
Copy link
Contributor

@michael1011 michael1011 commented Mar 31, 2018

Added the command line flags conf_target and sat_per_byte to the command closeallchannels.

Was requested by joaoalmeida on Slack.

@halseth
Copy link
Collaborator

@halseth halseth commented Apr 17, 2018

Loading

@halseth halseth requested a review from wpaulino Apr 19, 2018
Copy link
Collaborator

@wpaulino wpaulino left a comment

Thanks for the PR! The changes look good to me other than some minor nits. Could you also squash both commits into one?

Loading

inactive channels and proceed to close them.`,
inactive channels and proceed to close them.
In the case of a cooperative closure, One can manually set the fee to
Copy link
Collaborator

@wpaulino wpaulino May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/One/one

Loading

cli.Int64Flag{
Name: "conf_target",
Usage: "(optional) the number of blocks that the " +
"transaction *should* confirm in, will be " +
Copy link
Collaborator

@wpaulino wpaulino May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rephrase this to specify that these are the closing transactions of the channels being closed?

Loading

Name: "sat_per_byte",
Usage: "(optional) a manual fee expressed in " +
"sat/byte that should be used when crafting " +
"the transaction",
Copy link
Collaborator

@wpaulino wpaulino May 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

Loading

cmd/lncli/commands.go Show resolved Hide resolved
Loading
@Roasbeef Roasbeef added this to the 0.5 milestone May 2, 2018
@michael1011 michael1011 force-pushed the master branch 2 times, most recently from 4b715fb to c998bd2 May 15, 2018
@michael1011
Copy link
Contributor Author

@michael1011 michael1011 commented May 15, 2018

Sorry for responding so late. I completely forgot about this pr 😕

Loading

@Roasbeef Roasbeef removed this from the 0.5 milestone Aug 15, 2018
@Roasbeef Roasbeef added this to the 0.5.1 milestone Aug 15, 2018
@halseth halseth removed this from the 0.5.1 milestone Sep 20, 2018
@halseth halseth added this to the 0.5.2 milestone Sep 20, 2018
@Roasbeef Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019
inactive channels and proceed to close them.`,
inactive channels and proceed to close them.
In the case of cooperative closures, One can manually set the fee to
Copy link
Collaborator

@wpaulino wpaulino Feb 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/One/one

Loading

halseth
halseth approved these changes May 9, 2019
Copy link
Collaborator

@halseth halseth left a comment

LGTM 👍

Loading

@halseth
Copy link
Collaborator

@halseth halseth commented May 9, 2019

Oldie but goodie.

@michael1011 Can you give it a rebase? 😄

Loading

@michael1011
Copy link
Contributor Author

@michael1011 michael1011 commented May 10, 2019

Done @halseth

Loading

@Roasbeef Roasbeef merged commit 12607c9 into lightningnetwork:master Jun 4, 2019
2 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants