Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added conf_target and sat_per_byte to closeallchannels #990

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
5 participants
@michael1011
Copy link
Contributor

commented Mar 31, 2018

Added the command line flags conf_target and sat_per_byte to the command closeallchannels.

Was requested by joaoalmeida on Slack.

@michael1011 michael1011 force-pushed the michael1011:master branch 2 times, most recently from 070cba4 to 23c4f32 Apr 4, 2018

@halseth

This comment has been minimized.

Copy link
Collaborator

commented Apr 17, 2018

@halseth halseth requested a review from wpaulino Apr 19, 2018

@wpaulino
Copy link
Collaborator

left a comment

Thanks for the PR! The changes look good to me other than some minor nits. Could you also squash both commits into one?

inactive channels and proceed to close them.`,
inactive channels and proceed to close them.
In the case of a cooperative closure, One can manually set the fee to

This comment has been minimized.

Copy link
@wpaulino

wpaulino May 1, 2018

Collaborator

s/One/one

cli.Int64Flag{
Name: "conf_target",
Usage: "(optional) the number of blocks that the " +
"transaction *should* confirm in, will be " +

This comment has been minimized.

Copy link
@wpaulino

wpaulino May 1, 2018

Collaborator

Could you rephrase this to specify that these are the closing transactions of the channels being closed?

Name: "sat_per_byte",
Usage: "(optional) a manual fee expressed in " +
"sat/byte that should be used when crafting " +
"the transaction",

This comment has been minimized.

Copy link
@wpaulino

wpaulino May 1, 2018

Collaborator

Same comment as above.

Show resolved Hide resolved cmd/lncli/commands.go

@Roasbeef Roasbeef added this to the 0.5 milestone May 2, 2018

@michael1011 michael1011 force-pushed the michael1011:master branch 2 times, most recently from 4b715fb to c998bd2 May 15, 2018

@michael1011

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2018

Sorry for responding so late. I completely forgot about this pr 😕

@Roasbeef Roasbeef modified the milestones: 0.5, 0.5.1 Aug 15, 2018

@halseth halseth modified the milestones: 0.5.1, 0.5.2 Sep 20, 2018

@Roasbeef Roasbeef removed this from the 0.5.2 milestone Jan 16, 2019

inactive channels and proceed to close them.`,
inactive channels and proceed to close them.
In the case of cooperative closures, One can manually set the fee to

This comment has been minimized.

Copy link
@wpaulino

wpaulino Feb 2, 2019

Collaborator

Nit: s/One/one

@michael1011 michael1011 force-pushed the michael1011:master branch from c998bd2 to e5f01aa Feb 6, 2019

@halseth

halseth approved these changes May 9, 2019

Copy link
Collaborator

left a comment

LGTM 👍

@halseth

This comment has been minimized.

Copy link
Collaborator

commented May 9, 2019

Oldie but goodie.

@michael1011 Can you give it a rebase? 😄

@michael1011 michael1011 force-pushed the michael1011:master branch from e5f01aa to bb28d3a May 10, 2019

@michael1011

This comment has been minimized.

Copy link
Contributor Author

commented May 10, 2019

Done @halseth

@Roasbeef Roasbeef merged commit 12607c9 into lightningnetwork:master Jun 4, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 60.283%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.