From 455fe5d2bad9b7c6980d6fd809571c62181386fb Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 19 Nov 2025 10:57:48 +0100 Subject: [PATCH] cdp: use default value for grantUniveralAccess In createIsolatedWorld, we set a default value to false for optional grantUniveralAccess parameter. --- src/cdp/domains/page.zig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/cdp/domains/page.zig b/src/cdp/domains/page.zig index f1aa83e9d..93cf5a26e 100644 --- a/src/cdp/domains/page.zig +++ b/src/cdp/domains/page.zig @@ -20,6 +20,7 @@ const std = @import("std"); const Page = @import("../../browser/page.zig").Page; const timestampF = @import("../../datetime.zig").timestamp; const Notification = @import("../../notification.zig").Notification; +const log = @import("../../log.zig"); const Allocator = std.mem.Allocator; @@ -133,10 +134,10 @@ fn createIsolatedWorld(cmd: anytype) !void { const params = (try cmd.params(struct { frameId: []const u8, worldName: []const u8, - grantUniveralAccess: bool, + grantUniveralAccess: bool = false, })) orelse return error.InvalidParams; if (!params.grantUniveralAccess) { - std.debug.print("grantUniveralAccess == false is not yet implemented", .{}); + log.warn(.cdp, "not implemented", .{ .feature = "grantUniveralAccess == false is not yet implemented" }); // When grantUniveralAccess == false and the client attempts to resolve // or otherwise access a DOM or other JS Object from another context that should fail. }