From 0c2f0b78aa2e2fcb685152f8412a8613f07a3970 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Tue, 18 Jun 2024 16:03:44 +0200 Subject: [PATCH 1/2] ci: add --security-opt seccomp=unconfined docker option It seems docker blocks io_uring by default using seccomp. see tigerbeetle/tigerbeetle#1995 and moby/moby#46762 --- .github/workflows/wpt.yml | 5 +++++ .github/workflows/zig-test.yml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/workflows/wpt.yml b/.github/workflows/wpt.yml index dac11184f..e883b0a7a 100644 --- a/.github/workflows/wpt.yml +++ b/.github/workflows/wpt.yml @@ -50,6 +50,11 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} + # docker blocks io_uring syscalls by default now. + # see https://github.com/tigerbeetle/tigerbeetle/pull/1995 + # see https://github.com/moby/moby/pull/46762 + options: "--security-opt seccomp=unconfined" + steps: - uses: actions/checkout@v4 with: diff --git a/.github/workflows/zig-test.yml b/.github/workflows/zig-test.yml index eacd50471..4f6f469de 100644 --- a/.github/workflows/zig-test.yml +++ b/.github/workflows/zig-test.yml @@ -100,6 +100,11 @@ jobs: username: ${{ github.actor }} password: ${{ secrets.GITHUB_TOKEN }} + # docker blocks io_uring syscalls by default now. + # see https://github.com/tigerbeetle/tigerbeetle/pull/1995 + # see https://github.com/moby/moby/pull/46762 + options: "--security-opt seccomp=unconfined" + steps: - uses: actions/checkout@v4 with: From 33ec30094727b6788b51e869b407a5ecb61c1245 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Tue, 18 Jun 2024 16:05:21 +0200 Subject: [PATCH 2/2] ci: run ci on .github changes --- .github/workflows/wpt.yml | 2 ++ .github/workflows/zig-test.yml | 2 ++ 2 files changed, 4 insertions(+) diff --git a/.github/workflows/wpt.yml b/.github/workflows/wpt.yml index e883b0a7a..ddfadf81e 100644 --- a/.github/workflows/wpt.yml +++ b/.github/workflows/wpt.yml @@ -17,6 +17,7 @@ on: - "src/*.zig" - "tests/wpt/**" - "vendor/**" + - ".github/**" pull_request: # By default GH trigger on types opened, synchronize and reopened. @@ -33,6 +34,7 @@ on: - "src/*.zig" - "tests/wpt/**" - "vendor/**" + - ".github/**" # Allows you to run this workflow manually from the Actions tab workflow_dispatch: diff --git a/.github/workflows/zig-test.yml b/.github/workflows/zig-test.yml index 4f6f469de..5608747e3 100644 --- a/.github/workflows/zig-test.yml +++ b/.github/workflows/zig-test.yml @@ -16,6 +16,7 @@ on: - "src/**/*.zig" - "src/*.zig" - "vendor/zig-js-runtime" + - ".github/**" pull_request: # By default GH trigger on types opened, synchronize and reopened. @@ -31,6 +32,7 @@ on: - "src/**/*.zig" - "src/*.zig" - "vendor/**" + - ".github/**" # Allows you to run this workflow manually from the Actions tab workflow_dispatch: