Implement ImportMeta callback #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first time `import.meta` is called within a module, this callback is called and we can populate it with whatever fields we want. For WebAPI, the important field is `url`: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import.meta Depends on: lightpanda-io/zig-v8-fork#80
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first time
import.metais called within a module, this callback is called and we can populate it with whatever fields we want. For WebAPI, the important field isurl:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import.meta
Also fixed a URL.stitch case, and fixed 2 module caching issues, one where we were caching after the value was needed, and one where we were potentially caching a relative URL.
Depends on: lightpanda-io/zig-v8-fork#80