From dfe9d0f686b5124bf4e5fdd90a6eb2f1637195c3 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Tue, 18 Mar 2025 17:47:49 +0100 Subject: [PATCH 1/5] build: accept macos x86_64 --- build.zig | 4 ---- 1 file changed, 4 deletions(-) diff --git a/build.zig b/build.zig index 015e3cd..444782b 100644 --- a/build.zig +++ b/build.zig @@ -198,10 +198,6 @@ pub fn packages(comptime vendor_path: []const u8) type { break :blk; }, .macos => blk: { - if (arch != .aarch64) { - std.debug.print("only aarch64 are supported on macos builds\n", .{}); - return error.ArchNotSupported; - } break :blk; }, else => return error.OsNotSupported, From 5794ed7a0704ab26544248c93b3dc0cec53bec4f Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 19 Mar 2025 09:27:48 +0100 Subject: [PATCH 2/5] ci: add macos x86_64 test --- .github/workflows/zig-test.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/zig-test.yml b/.github/workflows/zig-test.yml index 48a6291..cf35818 100644 --- a/.github/workflows/zig-test.yml +++ b/.github/workflows/zig-test.yml @@ -87,3 +87,27 @@ jobs: - name: zig build test run: zig build test -Dengine=v8 + + zig-test-macos-x86_64: + env: + ARCH: x86_64 + OS: macos + + # Don't run the CI with draft PR. + if: github.event.pull_request.draft == false + + runs-on: macos-13 + + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + submodules: true + + - uses: ./.github/actions/install + with: + os: ${{env.OS}} + arch: ${{env.ARCH}} + + - name: zig build test + run: zig build test -Dengine=v8 From 430d3a84975e58f0dc9277cee9e177f9e6e22edf Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 19 Mar 2025 09:39:33 +0100 Subject: [PATCH 3/5] ci: install apt-get only on linux --- .github/actions/install/action.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/actions/install/action.yml b/.github/actions/install/action.yml index 3e766c3..2db0a6d 100644 --- a/.github/actions/install/action.yml +++ b/.github/actions/install/action.yml @@ -51,7 +51,9 @@ runs: wget -O ${{ inputs.cache-dir }}/v8/libc_v8.a https://github.com/lightpanda-io/zig-v8-fork/releases/download/${{ inputs.zig-v8 }}/libc_v8_${{ inputs.v8 }}_${{ inputs.os }}_${{ inputs.arch }}.a - - run: sudo apt-get install -yq libglib2.0-dev + - name: Install apt deps + if: ${{ inputs.os == 'linux' }} + run: sudo apt-get install -yq libglib2.0-dev shell: bash - name: install v8 From c7184158ea3655bff863dd5b7b2843104e0e57d8 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 19 Mar 2025 09:43:39 +0100 Subject: [PATCH 4/5] ci: add macos aarch64 test --- .github/workflows/zig-test.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/zig-test.yml b/.github/workflows/zig-test.yml index cf35818..2e7585d 100644 --- a/.github/workflows/zig-test.yml +++ b/.github/workflows/zig-test.yml @@ -111,3 +111,27 @@ jobs: - name: zig build test run: zig build test -Dengine=v8 + + zig-test-macos-aarch64: + env: + ARCH: aarch64 + OS: macos + + # Don't run the CI with draft PR. + if: github.event.pull_request.draft == false + + runs-on: macos-latest + + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + submodules: true + + - uses: ./.github/actions/install + with: + os: ${{env.OS}} + arch: ${{env.ARCH}} + + - name: zig build test + run: zig build test -Dengine=v8 From 9f6c35867f936d3161965ea0ec04194dd444e188 Mon Sep 17 00:00:00 2001 From: Pierre Tachoire Date: Wed, 19 Mar 2025 09:44:50 +0100 Subject: [PATCH 5/5] ci: add linux aarch64 test --- .github/workflows/zig-test.yml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/.github/workflows/zig-test.yml b/.github/workflows/zig-test.yml index 2e7585d..f9edf91 100644 --- a/.github/workflows/zig-test.yml +++ b/.github/workflows/zig-test.yml @@ -135,3 +135,27 @@ jobs: - name: zig build test run: zig build test -Dengine=v8 + + zig-test-linux-aarch64: + env: + ARCH: aarch64 + OS: linux + + # Don't run the CI with draft PR. + if: github.event.pull_request.draft == false + + runs-on: ubuntu-24.04-arm + + steps: + - uses: actions/checkout@v4 + with: + fetch-depth: 0 + submodules: true + + - uses: ./.github/actions/install + with: + os: ${{env.OS}} + arch: ${{env.ARCH}} + + - name: zig build test + run: zig build test -Dengine=v8