Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp support && Make compatibility with latest Joi #28

Merged
merged 10 commits into from Oct 25, 2017

Conversation

Projects
None yet
2 participants
@mooyoul
Copy link
Contributor

commented Oct 19, 2017

Summary

I've added timestamp (Joi.date().timestamp()) support and made compatibility with latest Joi, without losing backward compatibility (Joi v6.10.1 for example)

Changes

  1. fixed broken Joi.string().regex() support with latest Joi
  2. bump joi dev dependency version
  3. added Joi.date().timestamp() support

Affected Issues

Closes #13
Closes #20
Closes #27

mooyoul added some commits Oct 19, 2017

@mooyoul

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

Plus:

Required action after merge

  • bump package version
  • publish to npm

Cheers 🍻

@mooyoul

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

Currently Travis is failing, because yarn dropped support of old node.js runtimes.
It looks that we need to update minimum node.js version

@mooyoul

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

Okay, build failed again.
at this time, yarn claims that Joi requires node version greater than or equal to Node.js v8.

I've digged further details, and found this: hapijs/joi#1328
From Joi v13, Joi changed Node.js v8 as minimum supported node.js version, because they've changed their codebase to use default parameter assignment.

So i'm going to change our devDependency to use joi v12.

mooyoul added some commits Oct 19, 2017

@mooyoul

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

Okay, Test Passed ;)

@mooyoul mooyoul referenced this pull request Oct 19, 2017

Merged

bump joi-to-json-schema #17

@lightsofapollo

This comment has been minimized.

Copy link
Owner

commented Oct 23, 2017

Will land this later today or early tomorrow. Thanks for the updates !

@lightsofapollo lightsofapollo merged commit 2e1f39a into lightsofapollo:master Oct 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lightsofapollo

This comment has been minimized.

Copy link
Owner

commented Oct 25, 2017

in v3.1.0

@mooyoul

This comment has been minimized.

Copy link
Contributor Author

commented Oct 26, 2017

Thanks! 😄

@mooyoul mooyoul deleted the balmbees:latest-joi branch Oct 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.