Handle checkbox indeterminate state at the DOM level #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for lightspeed-flame ready! Built with commit f3e16fe |
|
Deploy preview for lightspeed-flame ready! Built with commit a203109 |
glambert
reviewed
Jan 21, 2020
| </Wrapper> | ||
| ), | ||
| ({ indeterminate, checked, css, className, ...restProps }, ref) => { | ||
| return ( |
There was a problem hiding this comment.
Is there a need to go from an implicit to explicit return?
glambert
approved these changes
Jan 22, 2020
|
This is not released yet, right? |
It's released: https://github.com/lightspeed/flame/releases/tag/%40lightspeed%2Fflame%401.2.11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need to forward the indeterminate state to the component. ez-pz
closes #72
How to test?
yarn testChecklist