Skip to content
This repository was archived by the owner on Mar 6, 2025. It is now read-only.

Conversation

@altuner
Copy link
Contributor

@altuner altuner commented Jun 9, 2023

Description

What does this PR do?

PR checklist for examples

Check these items before merging the PR.

  • Each example contains a README file.
  • README documents all steps and variables required to run the example. The simplest way to confirm this is to follow the instructions on a clean machine.
  • README file contains the links to the official documentation with relevant configuration and to the metrics published if that is available.
  • Used images of apps and collectors have to be pinned, "latest" should never be used.
  • Evidences with screenshots provided from the reviewer.
  • Includes a file called metrics.csv with metrics produced by the example.
    The file should have these 5 headings: Name, Description, Unit, DataType, Attributes.
    Description is not provided for all metrics, so it may be blank. Attributes are also not always provided. When there are multiple attributes on a metric reord they should be space separated.
  • Dashboard provided with example and put to the folder "dashboard" inside the example folder.
  • At least one screenshot of the proposed dashboard is included in this PR. If you're proposing substantive changes to queries or new queries then please ensure your screenshot shows relevant data.
  • All chart names in the dashboard are in Title case.
  • All query names in the dashboard are lower case letters, beginning the first query of each chart as "a" and proceeding alphabetically ... "b", "c", etcetera.

@altuner altuner changed the title (WIP) azure monitor example Azure monitor example Jun 13, 2023
Copy link
Contributor

@nslaughter nslaughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're the first to make Azure terraform, so you'll get some latitude for inventing the convention (with the help of Azure best practice docs and feedback of peers).

Here are some notes on convention based on that:

When naming things in terraform use the Azure recos for abbreviations on resource types at https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations and try to apply the following template for an Azure best practice naming convention: <resource-abbreviation>_<demo-name>_qa (see: https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-naming).

@altuner altuner force-pushed the azure branch 6 times, most recently from dbee878 to 11b4b45 Compare June 21, 2023 19:47
@nslaughter nslaughter merged commit 756b64e into main Jun 29, 2023
@nslaughter nslaughter deleted the azure branch June 29, 2023 16:39
altuner added a commit that referenced this pull request Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants