Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

icon loading when searching #7

Closed
ligi opened this issue Jan 15, 2013 · 4 comments
Closed

icon loading when searching #7

ligi opened this issue Jan 15, 2013 · 4 comments
Labels
bug

Comments

@ligi
Copy link
Owner

ligi commented Jan 15, 2013

after the latest awesome speed improvements by @jfreax there is a problem when searching sometimes the icons are not loaded
This was referenced Jan 15, 2013
Closed
Merged
@jfreax
Copy link
Contributor

jfreax commented Jan 16, 2013

Is this bug still present after #9 & #11 ?

@ligi
Copy link
Owner Author

ligi commented Jan 16, 2013

no it is gone - but it seems that "closes #7" does only work in commits - not in pull requests as i tried here: #9 (comment)
thanks!

@ligi ligi closed this as completed Jan 16, 2013
@ligi
Copy link
Owner Author

ligi commented Jan 16, 2013

PS: I am thinking about doing another doing another release with these changes - is that OK with you or do you have something else in the pipeline and I should better wait?
Also are you on Google+? Would love to get you in the contributors circle ..

@jfreax
Copy link
Contributor

jfreax commented Jan 16, 2013

Release it. Maybe I will look into some improvements on the text only view, I will post my ideas here first. But not in the next few days...

And yes, I am on G+. I added myself to the FAST User Community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ligi @jfreax