New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tab completion on Array causes ammonite to exit (#252) #258

Merged
merged 1 commit into from Nov 15, 2015

Conversation

Projects
None yet
2 participants
@ssanj
Contributor

ssanj commented Nov 12, 2015

Added a Try around the awaitResponse method to prevent an Exception
killing the Ammonite Repl. The awaitResponse method throws an Exception
if a match can't be found for a completion.

The Failure case simply returns an empty List[pressy.Member]. This seems
like the simplest and least invasive fix for issue #252, although it may
not be ideal.

Add fix for #252
Added a Try around the awaitResponse method to prevent an Exception
killing the Ammonite Repl. The awaitResponse method throws an Exception
if a match can't be found for a completion.

The Failure case simply returns an empty List[pressy.Member]. This seems
like the simplest and least invasive fix for issue #252, although it may
not be ideal.

lihaoyi added a commit that referenced this pull request Nov 15, 2015

Merge pull request #258 from ssanj/master
Fix Tab completion on Array causes ammonite to exit (#252)

@lihaoyi lihaoyi merged commit 36c2449 into lihaoyi:master Nov 15, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@lihaoyi

This comment has been minimized.

Owner

lihaoyi commented Nov 15, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment