Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add beforeExitHooks for cleanup before repl exits #581

Merged
merged 1 commit into from Apr 23, 2017

Conversation

Projects
None yet
3 participants
@emanresusername
Copy link
Contributor

emanresusername commented Mar 21, 2017

inspired by #121 but not exactly what we were discussing there
not sure if this is the best (or even a good 馃槄 ) way to do this
but really just wanted something that worked like this and this handled that usecase well enough for me :)

glad to hear other thoughts/suggestions/improvements/etc

@emanresusername emanresusername force-pushed the emanresusername:before-exit branch from ba79f86 to 0914bae Mar 21, 2017

@deusaquilus

This comment has been minimized.

Copy link

deusaquilus commented Mar 22, 2017

I'm also seeing issues in the Travis Scala 2.10.6 build and I don't understand the error at all. Maybe this build is flaky?

@emanresusername

This comment has been minimized.

Copy link
Contributor Author

emanresusername commented Mar 22, 2017

yeah, i was getting something about a class.bak file somewhere not being found, pretty sure it's not related to the code changes here @lihaoyi any ideas?

@lihaoyi

This comment has been minimized.

Copy link
Owner

lihaoyi commented Apr 23, 2017

Yeah that's just a flake; we can ignore it, unless you want to dig into why it's happening (I haven't had the time to)

@lihaoyi

This comment has been minimized.

Copy link
Owner

lihaoyi commented Apr 23, 2017

Looks good to me

@lihaoyi lihaoyi merged commit de2b9f2 into lihaoyi:master Apr 23, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

jhnsmth added a commit to jhnsmth/Ammonite that referenced this pull request May 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.