New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete: blacklisted anything that comes from Any #755

merged 3 commits into from Mar 1, 2018


None yet
2 participants

scalway commented Feb 22, 2018

We decide to filter out all methods that comes with Any.

There was two options. One to edit Pressy.scala:57:

      blacklist(s.fullNameAsName('.').decoded) ||
      s.fullNameAsName('.').decode.startsWith("scala.Any.") || //this line
      s.isImplicit ||

but then when people'll press tab then it'll never complete into full name (eg ".toString") even if it is the only option.

And changes mede here.
They'll be completed when it is the only option and show also definitions after second Tab.


This comment has been minimized.


scalway commented Feb 22, 2018

demn... 💯


This comment has been minimized.


lihaoyi commented Mar 1, 2018

looks good

@lihaoyi lihaoyi merged commit ad4629d into lihaoyi:master Mar 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment