Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cherry pick 4.3 #519

Merged
merged 6 commits into from Jun 5, 2019

Conversation

Projects
None yet
5 participants
@Simperfit
Copy link
Contributor

commented Jun 5, 2019

Fix #518

gnutix added some commits May 22, 2019

Show resolved Hide resolved .travis.yml Outdated
Update .travis.yml
Co-Authored-By: Alexis Lefebvre <alexislefebvre@users.noreply.github.com>

@Simperfit Simperfit force-pushed the izisolutions:feature/cherry-pick-4.3 branch from 7487143 to 477fbe0 Jun 5, 2019

@Simperfit Simperfit force-pushed the izisolutions:feature/cherry-pick-4.3 branch from 477fbe0 to 072fa22 Jun 5, 2019

@alexislefebvre alexislefebvre merged commit 464c7a2 into liip:2.x Jun 5, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@alexislefebvre

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Thanks @Simperfit!

@Simperfit Simperfit deleted the izisolutions:feature/cherry-pick-4.3 branch Jun 5, 2019

// Compatibility layer for Symfony 4.3+
if (class_exists('Symfony\Bundle\FrameworkBundle\KernelBrowser')) {
class_alias('Symfony\Bundle\FrameworkBundle\KernelBrowser', 'Symfony\Bundle\FrameworkBundle\Client');

This comment has been minimized.

Copy link
@nicolas-grekas

nicolas-grekas Jun 5, 2019

hum, well, noooooo
Don't miss reverting depending on how we manage to fix symfony/symfony#31762

This comment has been minimized.

Copy link
@Simperfit

Simperfit Jun 5, 2019

Author Contributor

I will add it to my todolist to revert in both 2.x and 3.x when the fix comes out

This comment has been minimized.

Copy link
@alexislefebvre

alexislefebvre Jun 5, 2019

Collaborator

Thanks @nicolas-grekas, I created an issue to keep track of this: #520

@allartk

This comment has been minimized.

Copy link

commented Jun 6, 2019

Symfony reverted the deletion of Symfony\Bundle\FrameworkBundle\Client in 4.3.1

symfony/framework-bundle@6d125a8

Obviously, the result is:
PHP Fatal error: Uncaught Cannot declare class Symfony\Bundle\FrameworkBundle\Client, because the name is already in use

@alexislefebvre

This comment has been minimized.

Copy link
Collaborator

commented Jun 6, 2019

Yes, please try the possible solution:

This should work if you downgrade to 2.0.0-alpha15 or use Symfony 4.3.0.

See #521 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.