Skip to content

Exclude Tests directory on composer archive - #274

Merged
havvg merged 1 commit into
liip:masterfrom
BedrockStreaming:master
Dec 2, 2013
Merged

Exclude Tests directory on composer archive#274
havvg merged 1 commit into
liip:masterfrom
BedrockStreaming:master

Conversation

@oziks

@oziks oziks commented Nov 29, 2013

Copy link
Copy Markdown
Contributor

Hi,

I got troubles when attempted to install the bundle with composer install --dev --prefer-dist.

When archiving sources, it throw this exception due to the cyrilic characters:

[BadMethodCallException]
  Entry Tests/Fixtures/assets/АГГЗ.jpeg cannot be created: phar error: invalid path "Tests/Fixtures/assets/АГГЗ.jpeg" contains illegal character

To solve it, I excluded the tests directory on archive creation:

"archive": {
    "exclude": ["/Tests"]
},

Thanks.

@havvg

havvg commented Dec 1, 2013

Copy link
Copy Markdown
Contributor

Could you merge the commits?

@oziks

oziks commented Dec 1, 2013

Copy link
Copy Markdown
Contributor Author

Done !

havvg added a commit that referenced this pull request Dec 2, 2013
Exclude Tests directory on composer archive
@havvg
havvg merged commit e8e9da1 into liip:master Dec 2, 2013
@oziks

oziks commented Dec 2, 2013

Copy link
Copy Markdown
Contributor Author

Thanks :)

@oziks

oziks commented Dec 4, 2013

Copy link
Copy Markdown
Contributor Author

I still can not use your bundle on our AWS project cause we work with Satis to avoid our dependency with Github and satis build throw an exception on illegal character.

Could you please add a tag ?

@havvg

havvg commented Dec 4, 2013

Copy link
Copy Markdown
Contributor

Sorry, missed that. v0.17.0 includes the changes.

@KuiKui

KuiKui commented Dec 5, 2013

Copy link
Copy Markdown

Thanks 👌

@oziks

oziks commented Dec 5, 2013

Copy link
Copy Markdown
Contributor Author

After the composer/composer#2482 merge, it's working perfectly ;)

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants