Exclude Tests directory on composer archive - #274
Merged
Conversation
Contributor
|
Could you merge the commits? |
Contributor
Author
|
Done ! |
havvg
added a commit
that referenced
this pull request
Dec 2, 2013
Exclude Tests directory on composer archive
Contributor
Author
|
Thanks :) |
Contributor
Author
|
I still can not use your bundle on our AWS project cause we work with Satis to avoid our dependency with Github and satis build throw an exception on illegal character. Could you please add a tag ? |
Contributor
|
Sorry, missed that. v0.17.0 includes the changes. |
|
Thanks 👌 |
Contributor
Author
|
After the composer/composer#2482 merge, it's working perfectly ;) Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I got troubles when attempted to install the bundle with
composer install --dev --prefer-dist.When archiving sources, it throw this exception due to the cyrilic characters:
[BadMethodCallException] Entry Tests/Fixtures/assets/АГГЗ.jpeg cannot be created: phar error: invalid path "Tests/Fixtures/assets/АГГЗ.jpeg" contains illegal characterTo solve it, I excluded the tests directory on archive creation:
Thanks.