Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Tests directory on composer archive #274

Merged
merged 1 commit into from Dec 2, 2013
Merged

Exclude Tests directory on composer archive #274

merged 1 commit into from Dec 2, 2013

Conversation

@oziks
Copy link
Contributor

@oziks oziks commented Nov 29, 2013

Hi,

I got troubles when attempted to install the bundle with composer install --dev --prefer-dist.

When archiving sources, it throw this exception due to the cyrilic characters:

[BadMethodCallException]
  Entry Tests/Fixtures/assets/АГГЗ.jpeg cannot be created: phar error: invalid path "Tests/Fixtures/assets/АГГЗ.jpeg" contains illegal character

To solve it, I excluded the tests directory on archive creation:

"archive": {
    "exclude": ["/Tests"]
},

Thanks.

@havvg
Copy link
Contributor

@havvg havvg commented Dec 1, 2013

Could you merge the commits?

@oziks
Copy link
Contributor Author

@oziks oziks commented Dec 1, 2013

Done !

havvg added a commit that referenced this pull request Dec 2, 2013
Exclude Tests directory on composer archive
@havvg havvg merged commit e8e9da1 into liip:master Dec 2, 2013
1 check passed
1 check passed
default Scrutinizer: No new issues — Travis: Passed
Details
@oziks
Copy link
Contributor Author

@oziks oziks commented Dec 2, 2013

Thanks :)

@oziks
Copy link
Contributor Author

@oziks oziks commented Dec 4, 2013

I still can not use your bundle on our AWS project cause we work with Satis to avoid our dependency with Github and satis build throw an exception on illegal character.

Could you please add a tag ?

@havvg
Copy link
Contributor

@havvg havvg commented Dec 4, 2013

Sorry, missed that. v0.17.0 includes the changes.

@KuiKui
Copy link

@KuiKui KuiKui commented Dec 5, 2013

Thanks 👌

@oziks
Copy link
Contributor Author

@oziks oziks commented Dec 5, 2013

After the composer/composer#2482 merge, it's working perfectly ;)

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants