New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to php-cs-fixer 1.x and run fixer #927

Merged
merged 1 commit into from May 8, 2017

Conversation

Projects
None yet
4 participants
@robfrawley
Collaborator

robfrawley commented May 8, 2017

Q A
Branch? 1.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

The move to php-cs-fixer 2.x was done without migrating the .styleci.yml rules. This pull request reverts our require-dev dependency back to 1.x, amends the .php_cs.dist file for simplicity, and includes fixes from a php-cs-fixer run.

We'll be stuck with this version until the following are fixed:

@robfrawley robfrawley added this to the 1.8.0 milestone May 8, 2017

@cedricziel

This comment has been minimized.

Show comment
Hide comment
@cedricziel

cedricziel May 8, 2017

Collaborator

We should think about using the phar instead of pulling it in our dependency tree.

Collaborator

cedricziel commented May 8, 2017

We should think about using the phar instead of pulling it in our dependency tree.

@cedricziel cedricziel merged commit 610d4f5 into liip:1.0 May 8, 2017

3 checks passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 74.043%
Details

@robfrawley robfrawley referenced this pull request May 8, 2017

Merged

Release 1.8.0 #928

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran Aug 30, 2017

@robfrawley it seems that Style CI has given up with upgrade to 2.x php-cs-fixer, so probably it is better rewrite the .php_cs file instead and use new version and forget about .styleci.yml

shakaran commented Aug 30, 2017

@robfrawley it seems that Style CI has given up with upgrade to 2.x php-cs-fixer, so probably it is better rewrite the .php_cs file instead and use new version and forget about .styleci.yml

@robfrawley

This comment has been minimized.

Show comment
Hide comment
@robfrawley

robfrawley Aug 30, 2017

Collaborator

@shakaran Yes, I know the state of Style CI integration with php-cs-fixer is stalled. This was simply a quick fix; a more long-term solution needs to be implemented, for sure.

Collaborator

robfrawley commented Aug 30, 2017

@shakaran Yes, I know the state of Style CI integration with php-cs-fixer is stalled. This was simply a quick fix; a more long-term solution needs to be implemented, for sure.

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran Aug 30, 2017

@robfrawley would you accept a PR where I implement the exact same filters/fixers, etc in the .php_cs file? So php-cs-fixer 2.x version could be used again?

shakaran commented Aug 30, 2017

@robfrawley would you accept a PR where I implement the exact same filters/fixers, etc in the .php_cs file? So php-cs-fixer 2.x version could be used again?

@robfrawley

This comment has been minimized.

Show comment
Hide comment
@robfrawley

robfrawley Aug 30, 2017

Collaborator

Sure would. ;-)

Collaborator

robfrawley commented Aug 30, 2017

Sure would. ;-)

@shakaran

This comment has been minimized.

Show comment
Hide comment
@shakaran

shakaran commented Sep 12, 2017

@robfrawley Done PR #992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment